* [PATCH] crypto: qat - add missing header inclusion
@ 2025-05-20 16:11 Arnd Bergmann
2025-05-21 4:56 ` Cabiddu, Giovanni
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2025-05-20 16:11 UTC (permalink / raw)
To: Giovanni Cabiddu, Herbert Xu, David S. Miller, Karthikeyan Gopal,
Laurent M Coquerel, Suman Kumar Chakraborty
Cc: Arnd Bergmann, George Abraham P, qat-linux, linux-crypto,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without this header, building the new driver fails with:
In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
13 | pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
| ^~~~~~~~~~~~~~~~~~~~~~~
Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
index a716545a764c..9efee0053f3a 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
@@ -4,6 +4,7 @@
#define ADF_GEN2_PFVF_H
#include <linux/types.h>
+#include "adf_common_drv.h"
#include "adf_accel_devices.h"
#define ADF_GEN2_ERRSOU3 (0x3A000 + 0x0C)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
index 17d1b774d4a8..2c8708117f70 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
@@ -4,6 +4,7 @@
#define ADF_GEN4_PFVF_H
#include "adf_accel_devices.h"
+#include "adf_common_drv.h"
#ifdef CONFIG_PCI_IOV
void adf_gen4_init_pf_pfvf_ops(struct adf_pfvf_ops *pfvf_ops);
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: qat - add missing header inclusion
2025-05-20 16:11 [PATCH] crypto: qat - add missing header inclusion Arnd Bergmann
@ 2025-05-21 4:56 ` Cabiddu, Giovanni
2025-05-22 10:21 ` [PATCH v2] " Cabiddu, Giovanni
0 siblings, 1 reply; 4+ messages in thread
From: Cabiddu, Giovanni @ 2025-05-21 4:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Herbert Xu, David S. Miller, Karthikeyan Gopal,
Laurent M Coquerel, Suman Kumar Chakraborty, Arnd Bergmann,
George Abraham P, qat-linux, linux-crypto, linux-kernel
On Tue, May 20, 2025 at 06:11:36PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this header, building the new driver fails with:
>
> In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
> 13 | pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd. This occurs with CONFIG_PCI_IOV not set. Can this be added
to the commit message?
> ---
> drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> index a716545a764c..9efee0053f3a 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> +++ b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> @@ -4,6 +4,7 @@
> #define ADF_GEN2_PFVF_H
>
> #include <linux/types.h>
> +#include "adf_common_drv.h"
> #include "adf_accel_devices.h"
NIT. Can this be in alphabetical order?
>
> #define ADF_GEN2_ERRSOU3 (0x3A000 + 0x0C)
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
> index 17d1b774d4a8..2c8708117f70 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
> +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
> @@ -4,6 +4,7 @@
> #define ADF_GEN4_PFVF_H
>
> #include "adf_accel_devices.h"
> +#include "adf_common_drv.h"
>
> #ifdef CONFIG_PCI_IOV
> void adf_gen4_init_pf_pfvf_ops(struct adf_pfvf_ops *pfvf_ops);
Thanks,
--
Giovanni
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] crypto: qat - add missing header inclusion
2025-05-21 4:56 ` Cabiddu, Giovanni
@ 2025-05-22 10:21 ` Cabiddu, Giovanni
2025-05-23 11:27 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Cabiddu, Giovanni @ 2025-05-22 10:21 UTC (permalink / raw)
To: Arnd Bergmann, Herbert Xu
Cc: David S. Miller, Karthikeyan Gopal, Laurent M Coquerel,
Suman Kumar Chakraborty, Arnd Bergmann, George Abraham P,
qat-linux, linux-crypto, linux-kernel
On Wed, May 21, 2025 at 05:56:15AM +0100, Cabiddu, Giovanni wrote:
> On Tue, May 20, 2025 at 06:11:36PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Without this header, building the new driver fails with:
> >
> > In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
> > drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
> > drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
> > 13 | pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Thanks Arnd. This occurs with CONFIG_PCI_IOV not set. Can this be added
> to the commit message?
>
> > ---
> > drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
> > drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> > index a716545a764c..9efee0053f3a 100644
> > --- a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> > +++ b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> > @@ -4,6 +4,7 @@
> > #define ADF_GEN2_PFVF_H
> >
> > #include <linux/types.h>
> > +#include "adf_common_drv.h"
> > #include "adf_accel_devices.h"
> NIT. Can this be in alphabetical order?
---8<---
From: Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] crypto: qat - add missing header inclusion
Without this header, the build of the new qat_6xxx driver fails when
CONFIG_PCI_IOV is not set:
In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
13 | pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
| ^~~~~~~~~~~~~~~~~~~~~~~
Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
---
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
index a716545a764c..34a63cf40db2 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
@@ -5,6 +5,7 @@
#include <linux/types.h>
#include "adf_accel_devices.h"
+#include "adf_common_drv.h"
#define ADF_GEN2_ERRSOU3 (0x3A000 + 0x0C)
#define ADF_GEN2_ERRSOU5 (0x3A000 + 0xD8)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
index 17d1b774d4a8..2c8708117f70 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
@@ -4,6 +4,7 @@
#define ADF_GEN4_PFVF_H
#include "adf_accel_devices.h"
+#include "adf_common_drv.h"
#ifdef CONFIG_PCI_IOV
void adf_gen4_init_pf_pfvf_ops(struct adf_pfvf_ops *pfvf_ops);
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] crypto: qat - add missing header inclusion
2025-05-22 10:21 ` [PATCH v2] " Cabiddu, Giovanni
@ 2025-05-23 11:27 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2025-05-23 11:27 UTC (permalink / raw)
To: Cabiddu, Giovanni
Cc: Arnd Bergmann, David S. Miller, Karthikeyan Gopal,
Laurent M Coquerel, Suman Kumar Chakraborty, Arnd Bergmann,
George Abraham P, qat-linux, linux-crypto, linux-kernel
On Thu, May 22, 2025 at 11:21:41AM +0100, Cabiddu, Giovanni wrote:
>
> Without this header, the build of the new qat_6xxx driver fails when
> CONFIG_PCI_IOV is not set:
>
> In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
> 13 | pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
> 2 files changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-23 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-20 16:11 [PATCH] crypto: qat - add missing header inclusion Arnd Bergmann
2025-05-21 4:56 ` Cabiddu, Giovanni
2025-05-22 10:21 ` [PATCH v2] " Cabiddu, Giovanni
2025-05-23 11:27 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox