From: Tycho Andersen <tycho@kernel.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Ashish Kalra <ashish.kalra@amd.com>,
John Allen <john.allen@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Ard Biesheuvel <ardb@kernel.org>,
Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>,
Kishon Vijay Abraham I <kvijayab@amd.com>,
Alexey Kardashevskiy <aik@amd.com>,
Nikunj A Dadhania <nikunj@amd.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Kim Phillips <kim.phillips@amd.com>,
Sean Christopherson <seanjc@google.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 2/2] crypto/ccp: Skip SNP_INIT if preparation fails
Date: Wed, 8 Apr 2026 08:06:51 -0600 [thread overview]
Message-ID: <adZgbOx6-JPhKMU-@tycho.pizza> (raw)
In-Reply-To: <d4f82d48-6f80-4e19-afd8-6f3df5a6d267@amd.com>
On Wed, Apr 08, 2026 at 08:17:44AM -0500, Tom Lendacky wrote:
> On 4/7/26 12:47, Tycho Andersen wrote:
> > From: "Tycho Andersen (AMD)" <tycho@kernel.org>
> >
> > During SNP_INIT, the firmware checks to see that the SNP enable bit is set
> > on all CPUs. If snp_prepare() failed because not all CPUs were online,
> > SNP_INIT will fail, so skip it.
>
> This should probably be more generic and state that if snp_prepare()
> fails for any reason then SNP_INIT will fail, so skip it.
Yep, thanks. I can send a v3 with all of these fixes.
And to preempt questions about sashiko:
https://sashiko.dev/#/patchset/20260407174713.439474-1-tycho%40kernel.org
The first one is bogus, but I also got it from AI when reviewing this
series: the previous code returned the error from the firmware as well
and killed initialization completely.
The other two are ones that were previously reported, I have fixes for
them but have not yet posted...
Tycho
prev parent reply other threads:[~2026-04-08 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 17:47 [PATCH v2 0/2] Skip SNP initialization if CPUs are offlined Tycho Andersen
2026-04-07 17:47 ` [PATCH v2 1/2] x86/sev: Do not initialize SNP if missing CPUs Tycho Andersen
2026-04-08 5:40 ` Nikunj A. Dadhania
2026-04-08 13:10 ` Tom Lendacky
2026-04-07 17:47 ` [PATCH v2 2/2] crypto/ccp: Skip SNP_INIT if preparation fails Tycho Andersen
2026-04-08 6:01 ` Nikunj A. Dadhania
2026-04-08 13:17 ` Tom Lendacky
2026-04-08 14:06 ` Tycho Andersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adZgbOx6-JPhKMU-@tycho.pizza \
--to=tycho@kernel.org \
--cc=Neeraj.Upadhyay@amd.com \
--cc=aik@amd.com \
--cc=ardb@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=john.allen@amd.com \
--cc=kim.phillips@amd.com \
--cc=kvijayab@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox