From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: Tycho Andersen <tycho@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Ard Biesheuvel" <ardb@kernel.org>,
Alexey Kardashevskiy <aik@amd.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Kim Phillips <kim.phillips@amd.com>,
Sean Christopherson <seanjc@google.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] crypto/ccp: Skip SNP_INIT if preparation fails
Date: Wed, 8 Apr 2026 11:31:18 +0530 [thread overview]
Message-ID: <f6170c40-5a36-440b-bcf0-b1c79bcfe639@amd.com> (raw)
In-Reply-To: <20260407174713.439474-3-tycho@kernel.org>
On 4/7/2026 11:17 PM, Tycho Andersen wrote:
> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
>
> During SNP_INIT, the firmware checks to see that the SNP enable bit is set
> on all CPUs. If snp_prepare() failed because not all CPUs were online,
> SNP_INIT will fail, so skip it.
>
> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
Reviewed-by: Nikunj A Dadhania <nikunj@amd.com>
> ---
> drivers/crypto/ccp/sev-dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index 939fa8aa155c..854263cbb256 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -1374,7 +1374,9 @@ static int __sev_snp_init_locked(int *error, unsigned int max_snp_asid)
> return -EOPNOTSUPP;
> }
>
> - snp_prepare();
> + rc = snp_prepare();
> + if (rc < 0)
> + return rc;
>
> /*
> * Starting in SNP firmware v1.52, the SNP_INIT_EX command takes a list
next prev parent reply other threads:[~2026-04-08 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 17:47 [PATCH v2 0/2] Skip SNP initialization if CPUs are offlined Tycho Andersen
2026-04-07 17:47 ` [PATCH v2 1/2] x86/sev: Do not initialize SNP if missing CPUs Tycho Andersen
2026-04-08 5:40 ` Nikunj A. Dadhania
2026-04-08 13:10 ` Tom Lendacky
2026-04-07 17:47 ` [PATCH v2 2/2] crypto/ccp: Skip SNP_INIT if preparation fails Tycho Andersen
2026-04-08 6:01 ` Nikunj A. Dadhania [this message]
2026-04-08 13:17 ` Tom Lendacky
2026-04-08 14:06 ` Tycho Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6170c40-5a36-440b-bcf0-b1c79bcfe639@amd.com \
--to=nikunj@amd.com \
--cc=aik@amd.com \
--cc=ardb@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=john.allen@amd.com \
--cc=kim.phillips@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=tycho@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox