From: Roland Dreier <rdreier@cisco.com>
To: "Francis Moreau" <francis.moro@gmail.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
helge.hafting@aitel.hist.no, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [CRYPTO] is it really optimized ?
Date: Tue, 17 Apr 2007 09:33:21 -0700 [thread overview]
Message-ID: <ada7isb3qr2.fsf@cisco.com> (raw)
In-Reply-To: <38b2ab8a0704170914h3a766236t47bc7e1c8de67662@mail.gmail.com> (Francis Moreau's message of "Tue, 17 Apr 2007 18:14:58 +0200")
> > I wonder if there's some way you can cache the last caller and reload
> > the key lazily (only when it changes).
>
> yes something that allows crypto drivers to detect if the key has
> changed would be good.
It seems trivial to keep the last key you were given and do a quick
memcmp in your setkey method to see if it's different from the last
key you pushed to hardware, and set a flag if it is. Then only do
your set_key() if you have a new key to pass to hardware.
I'm assuming the expense is in the aes_write() calls, and you could
avoid them if you know you're not writing something new.
- R.
next prev parent reply other threads:[~2007-04-17 16:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <38b2ab8a0704130630v4c840bd1w19f2a239f86a93b@mail.gmail.com>
2007-04-14 4:30 ` [CRYPTO] is it really optimized ? Herbert Xu
2007-04-14 13:15 ` Francis Moreau
2007-04-14 19:34 ` Herbert Xu
2007-04-14 19:44 ` Michael Halcrow
2007-04-15 11:06 ` Satyam Sharma
2007-04-15 14:31 ` Satyam Sharma
2007-04-15 15:31 ` Michael Halcrow
2007-04-15 16:10 ` Satyam Sharma
2007-04-14 21:10 ` Francis Moreau
2007-04-15 7:52 ` Herbert Xu
2007-04-16 8:37 ` Francis Moreau
2007-04-17 0:41 ` Herbert Xu
2007-04-17 12:36 ` Francis Moreau
2007-04-17 13:04 ` Evgeniy Polyakov
2007-04-17 13:42 ` Herbert Xu
2007-04-17 14:01 ` Francis Moreau
2007-04-17 15:08 ` Evgeniy Polyakov
2007-04-17 15:34 ` Francis Moreau
2007-04-17 15:57 ` Evgeniy Polyakov
2007-04-17 16:18 ` Francis Moreau
2007-04-17 17:07 ` Evgeniy Polyakov
2007-04-17 13:57 ` Francis Moreau
2007-04-17 13:40 ` Herbert Xu
2007-04-17 13:59 ` Francis Moreau
2007-04-17 14:02 ` Herbert Xu
2007-04-17 14:41 ` Francis Moreau
2007-04-17 15:40 ` Roland Dreier
2007-04-17 16:14 ` Francis Moreau
2007-04-17 16:33 ` Roland Dreier [this message]
2007-04-17 17:24 ` Francis Moreau
2007-04-17 17:34 ` Roland Dreier
2007-04-19 8:07 ` Francis Moreau
2007-04-23 13:56 ` Francis Moreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada7isb3qr2.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=francis.moro@gmail.com \
--cc=helge.hafting@aitel.hist.no \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox