* [PATCH] crypto/krb5: use kfree_sensitive() for derived key buffers
@ 2026-08-03 19:26 Jan Sebastian Götte
2026-08-15 1:26 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Jan Sebastian Götte @ 2026-08-03 19:26 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, David Howells
Cc: Jakub Kicinski, Michael Bommarito, Jeffrey Altman, linux-crypto,
linux-kernel, linux-hardening, Jan Sebastian Götte, stable
crypto_krb5_prepare_encryption() and crypto_krb5_prepare_checksum()
free the buffer holding the freshly derived keys with plain kfree(),
leaving the key material behind in the freed slab object.
Fixes: 3936f02bf2d3 ("crypto/krb5: Implement Kerberos crypto core")
Cc: stable@vger.kernel.org
Signed-off-by: Jan Sebastian Götte <linux@jaseg.de>
---
crypto/krb5/krb5_api.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/crypto/krb5/krb5_api.c b/crypto/krb5/krb5_api.c
index 03395b89cc61..b377f4f7558d 100644
--- a/crypto/krb5/krb5_api.c
+++ b/crypto/krb5/krb5_api.c
@@ -263,10 +263,10 @@ struct crypto_aead *crypto_krb5_prepare_encryption(const struct krb5_enctype *kr
goto err;
}
- kfree(keys.data);
+ kfree_sensitive(keys.data);
return ci;
err:
- kfree(keys.data);
+ kfree_sensitive(keys.data);
return ERR_PTR(ret);
}
EXPORT_SYMBOL(crypto_krb5_prepare_encryption);
@@ -333,10 +333,10 @@ struct crypto_shash *crypto_krb5_prepare_checksum(const struct krb5_enctype *krb
goto err;
}
- kfree(keys.data);
+ kfree_sensitive(keys.data);
return ci;
err:
- kfree(keys.data);
+ kfree_sensitive(keys.data);
return ERR_PTR(ret);
}
EXPORT_SYMBOL(crypto_krb5_prepare_checksum);
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto/krb5: use kfree_sensitive() for derived key buffers
2026-08-03 19:26 [PATCH] crypto/krb5: use kfree_sensitive() for derived key buffers Jan Sebastian Götte
@ 2026-08-15 1:26 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2026-08-15 1:26 UTC (permalink / raw)
To: Jan Sebastian Götte
Cc: David S. Miller, David Howells, Jakub Kicinski, Michael Bommarito,
Jeffrey Altman, linux-crypto, linux-kernel, linux-hardening,
stable
On Mon, Aug 03, 2026 at 09:26:21PM +0200, Jan Sebastian Götte wrote:
> crypto_krb5_prepare_encryption() and crypto_krb5_prepare_checksum()
> free the buffer holding the freshly derived keys with plain kfree(),
> leaving the key material behind in the freed slab object.
>
> Fixes: 3936f02bf2d3 ("crypto/krb5: Implement Kerberos crypto core")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jan Sebastian Götte <linux@jaseg.de>
> ---
> crypto/krb5/krb5_api.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-15 1:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 19:26 [PATCH] crypto/krb5: use kfree_sensitive() for derived key buffers Jan Sebastian Götte
2026-08-15 1:26 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox