From: Herbert Xu <herbert@gondor.apana.org.au>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ashish Kalra <ashish.kalra@amd.com>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: ccp - don't abuse kernel-doc comment format
Date: Mon, 10 Aug 2026 18:30:00 +1000 [thread overview]
Message-ID: <anmMCDkdRMEIsl0D@gondor.apana.org.au> (raw)
In-Reply-To: <20260730051710.1412969-1-rdunlap@infradead.org>
On Wed, Jul 29, 2026 at 10:17:10PM -0700, Randy Dunlap wrote:
> Use plain C "/*" notation for comments that are not in kernel-doc format
> to avoid kernel-doc warnings:
>
> Warning: include/uapi/linux/psp-sfs.h:18 expecting prototype for SFS().
> Prototype was for PAYLOAD_NAME_SIZE() instead
> Warning: include/uapi/linux/psp-sfs.h:46 This comment starts with '/**',
> but isn't a kernel-doc comment.
> * Seamless Firmware Support (SFS) IOC
>
> Fixes: 648dbccc03a0 ("crypto: ccp - Add AMD Seamless Firmware Servicing (SFS) driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Ashish Kalra <ashish.kalra@amd.com>
> Cc: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
>
> include/uapi/linux/psp-sfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-08-10 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 5:17 [PATCH] crypto: ccp - don't abuse kernel-doc comment format Randy Dunlap
2026-07-30 15:50 ` Tom Lendacky
2026-08-10 8:30 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anmMCDkdRMEIsl0D@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox