Linux cryptographic layer development
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Add TRNG node for x1e80100 SoC
@ 2025-12-10  5:36 Harshal Dev
  2025-12-10  5:36 ` [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: document x1e80100 Harshal Dev
  2025-12-10  5:36 ` [PATCH v2 2/2] arm64: dts: qcom: x1e80100: add TRNG node Harshal Dev
  0 siblings, 2 replies; 5+ messages in thread
From: Harshal Dev @ 2025-12-10  5:36 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
	Harshal Dev, Krzysztof Kozlowski, Wenjia Zhang, Dmitry Baryshkov

Add device-tree nodes to enable TRNG for x1e80100 SoC

Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
---
Changes in v2:
- Collected Tested-by and Reviewed-by tags.
- Link to v1: https://lore.kernel.org/r/20251124-trng_dt_binding_x1e80100-v1-0-b4eafa0f1077@oss.qualcomm.com

---
Harshal Dev (2):
      dt-bindings: crypto: qcom,prng: document x1e80100
      arm64: dts: qcom: x1e80100: add TRNG node

 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                  | 5 +++++
 2 files changed, 6 insertions(+)
---
base-commit: d13f3ac64efb868d09cb2726b1e84929afe90235
change-id: 20251124-trng_dt_binding_x1e80100-94ec1f83142b

Best regards,
-- 
Harshal Dev <harshal.dev@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: document x1e80100
  2025-12-10  5:36 [PATCH v2 0/2] Add TRNG node for x1e80100 SoC Harshal Dev
@ 2025-12-10  5:36 ` Harshal Dev
  2025-12-10  5:44   ` Krzysztof Kozlowski
  2025-12-10  5:36 ` [PATCH v2 2/2] arm64: dts: qcom: x1e80100: add TRNG node Harshal Dev
  1 sibling, 1 reply; 5+ messages in thread
From: Harshal Dev @ 2025-12-10  5:36 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
	Harshal Dev, Krzysztof Kozlowski, Wenjia Zhang

Document x1e80100 compatible for the True Random Number Generator.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Tested-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index ed7e16bd11d3..aa3c097a6acd 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -29,6 +29,7 @@ properties:
               - qcom,sm8550-trng
               - qcom,sm8650-trng
               - qcom,sm8750-trng
+              - qcom,x1e80100-trng
           - const: qcom,trng
 
   reg:

-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] arm64: dts: qcom: x1e80100: add TRNG node
  2025-12-10  5:36 [PATCH v2 0/2] Add TRNG node for x1e80100 SoC Harshal Dev
  2025-12-10  5:36 ` [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: document x1e80100 Harshal Dev
@ 2025-12-10  5:36 ` Harshal Dev
  1 sibling, 0 replies; 5+ messages in thread
From: Harshal Dev @ 2025-12-10  5:36 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
	Harshal Dev, Dmitry Baryshkov, Wenjia Zhang

The x1e80100 SoC has a True Random Number Generator, add the node with
the correct compatible set.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Tested-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 51576d9c935d..c17c02c347be 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -3033,6 +3033,11 @@ usb_1_ss2_qmpphy_dp_in: endpoint {
 			};
 		};
 
+		rng: rng@10c3000 {
+			compatible = "qcom,x1e80100-trng", "qcom,trng";
+			reg = <0x0 0x10c3000 0x0 0x1000>;
+		};
+
 		cnoc_main: interconnect@1500000 {
 			compatible = "qcom,x1e80100-cnoc-main";
 			reg = <0 0x01500000 0 0x14400>;

-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: document x1e80100
  2025-12-10  5:36 ` [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: document x1e80100 Harshal Dev
@ 2025-12-10  5:44   ` Krzysztof Kozlowski
  2025-12-10  7:00     ` Harshal Dev
  0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-10  5:44 UTC (permalink / raw)
  To: Harshal Dev, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Bjorn Andersson,
	Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
	Krzysztof Kozlowski, Wenjia Zhang

On 10/12/2025 06:36, Harshal Dev wrote:
> Document x1e80100 compatible for the True Random Number Generator.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Tested-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>


How did you test a binding? To remind - kernel tools and make is not
testing.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: document x1e80100
  2025-12-10  5:44   ` Krzysztof Kozlowski
@ 2025-12-10  7:00     ` Harshal Dev
  0 siblings, 0 replies; 5+ messages in thread
From: Harshal Dev @ 2025-12-10  7:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Bjorn Andersson,
	Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
	Krzysztof Kozlowski, Wenjia Zhang



On 12/10/2025 11:14 AM, Krzysztof Kozlowski wrote:
> On 10/12/2025 06:36, Harshal Dev wrote:
>> Document x1e80100 compatible for the True Random Number Generator.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> Tested-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
> 
> 
> How did you test a binding? To remind - kernel tools and make is not
> testing.
> 

Thanks Krzysztof, looks like b4 tool just auto-copied the tag to all patch-sets.
I'll remove it since there is no real 'test' for a DT binding.

Regards,
Harshal

> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-12-10  7:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-10  5:36 [PATCH v2 0/2] Add TRNG node for x1e80100 SoC Harshal Dev
2025-12-10  5:36 ` [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: document x1e80100 Harshal Dev
2025-12-10  5:44   ` Krzysztof Kozlowski
2025-12-10  7:00     ` Harshal Dev
2025-12-10  5:36 ` [PATCH v2 2/2] arm64: dts: qcom: x1e80100: add TRNG node Harshal Dev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox