* Re: [PATCH] crypto: ccp - Add support for PCI device 0x1134
2025-02-06 22:11 [PATCH] crypto: ccp - Add support for PCI device 0x1134 Devaraj Rangasamy
@ 2025-02-07 21:09 ` Tom Lendacky
2025-02-08 0:36 ` Mario Limonciello
2025-02-16 5:26 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Tom Lendacky @ 2025-02-07 21:09 UTC (permalink / raw)
To: Devaraj Rangasamy, John Allen, Herbert Xu, David S . Miller,
Mario Limonciello, linux-crypto, linux-kernel
Cc: Thomas Rijo-john, Rajib Mahapatra, Nimesh Easow
On 2/6/25 16:11, Devaraj Rangasamy wrote:
> PCI device 0x1134 shares same register features as PCI device 0x17E0.
> Hence reuse same data for the new PCI device ID 0x1134.
>
> Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/crypto/ccp/sp-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 248d98fd8c48..5357c4308da0 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -529,6 +529,7 @@ static const struct pci_device_id sp_pci_table[] = {
> { PCI_VDEVICE(AMD, 0x14CA), (kernel_ulong_t)&dev_vdata[5] },
> { PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
> { PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[6] },
> + { PCI_VDEVICE(AMD, 0x1134), (kernel_ulong_t)&dev_vdata[7] },
> { PCI_VDEVICE(AMD, 0x17E0), (kernel_ulong_t)&dev_vdata[7] },
> { PCI_VDEVICE(AMD, 0x156E), (kernel_ulong_t)&dev_vdata[8] },
> /* Last entry must be zero */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: ccp - Add support for PCI device 0x1134
2025-02-06 22:11 [PATCH] crypto: ccp - Add support for PCI device 0x1134 Devaraj Rangasamy
2025-02-07 21:09 ` Tom Lendacky
@ 2025-02-08 0:36 ` Mario Limonciello
2025-02-16 5:26 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Mario Limonciello @ 2025-02-08 0:36 UTC (permalink / raw)
To: Devaraj Rangasamy, Tom Lendacky, John Allen, Herbert Xu,
David S . Miller, linux-crypto, linux-kernel
Cc: Thomas Rijo-john, Rajib Mahapatra, Nimesh Easow
On 2/6/2025 16:11, Devaraj Rangasamy wrote:
> PCI device 0x1134 shares same register features as PCI device 0x17E0.
> Hence reuse same data for the new PCI device ID 0x1134.
>
> Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/crypto/ccp/sp-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 248d98fd8c48..5357c4308da0 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -529,6 +529,7 @@ static const struct pci_device_id sp_pci_table[] = {
> { PCI_VDEVICE(AMD, 0x14CA), (kernel_ulong_t)&dev_vdata[5] },
> { PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
> { PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[6] },
> + { PCI_VDEVICE(AMD, 0x1134), (kernel_ulong_t)&dev_vdata[7] },
> { PCI_VDEVICE(AMD, 0x17E0), (kernel_ulong_t)&dev_vdata[7] },
> { PCI_VDEVICE(AMD, 0x156E), (kernel_ulong_t)&dev_vdata[8] },
> /* Last entry must be zero */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: ccp - Add support for PCI device 0x1134
2025-02-06 22:11 [PATCH] crypto: ccp - Add support for PCI device 0x1134 Devaraj Rangasamy
2025-02-07 21:09 ` Tom Lendacky
2025-02-08 0:36 ` Mario Limonciello
@ 2025-02-16 5:26 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2025-02-16 5:26 UTC (permalink / raw)
To: Devaraj Rangasamy
Cc: Tom Lendacky, John Allen, David S . Miller, Mario Limonciello,
linux-crypto, linux-kernel, Thomas Rijo-john, Rajib Mahapatra,
Nimesh Easow
On Fri, Feb 07, 2025 at 03:41:52AM +0530, Devaraj Rangasamy wrote:
> PCI device 0x1134 shares same register features as PCI device 0x17E0.
> Hence reuse same data for the new PCI device ID 0x1134.
>
> Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
> ---
> drivers/crypto/ccp/sp-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 248d98fd8c48..5357c4308da0 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -529,6 +529,7 @@ static const struct pci_device_id sp_pci_table[] = {
> { PCI_VDEVICE(AMD, 0x14CA), (kernel_ulong_t)&dev_vdata[5] },
> { PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
> { PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[6] },
> + { PCI_VDEVICE(AMD, 0x1134), (kernel_ulong_t)&dev_vdata[7] },
> { PCI_VDEVICE(AMD, 0x17E0), (kernel_ulong_t)&dev_vdata[7] },
> { PCI_VDEVICE(AMD, 0x156E), (kernel_ulong_t)&dev_vdata[8] },
> /* Last entry must be zero */
> --
> 2.25.1
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread