* [PATCH v2] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:51 Javier Martinez Canillas
2016-10-19 9:19 ` Neil Armstrong
2016-10-25 3:40 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:51 UTC (permalink / raw)
To: linux-kernel
Cc: Jason Gunthorpe, Javier Martinez Canillas, Kevin Hilman,
Neil Armstrong, PrasannaKumar Muralidharan, Carlo Caione,
linux-amlogic, Herbert Xu, Matt Mackall, linux-arm-kernel,
linux-crypto
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias: platform:meson-rng
After this patch:
$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias: platform:meson-rng
alias: of:N*T*Camlogic,meson-rngC*
alias: of:N*T*Camlogic,meson-rng
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Remove unrelated changes added by mistake. Suggested by Jason Gunthorpe.
drivers/char/hw_random/meson-rng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
index 58bef39f7286..51864a509be7 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
{ .compatible = "amlogic,meson-rng", },
{},
};
+MODULE_DEVICE_TABLE(of, meson_rng_of_match);
static struct platform_driver meson_rng_driver = {
.probe = meson_rng_probe,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] hwrng: meson: Fix module autoload for OF registration
2016-10-17 19:51 [PATCH v2] hwrng: meson: Fix module autoload for OF registration Javier Martinez Canillas
@ 2016-10-19 9:19 ` Neil Armstrong
2016-10-25 3:40 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2016-10-19 9:19 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Herbert Xu, Kevin Hilman, Matt Mackall, Jason Gunthorpe,
linux-crypto, PrasannaKumar Muralidharan, Carlo Caione,
linux-amlogic, linux-arm-kernel
On 10/17/2016 09:51 PM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
> alias: platform:meson-rng
>
> After this patch:
>
> $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
> alias: platform:meson-rng
> alias: of:N*T*Camlogic,meson-rngC*
> alias: of:N*T*Camlogic,meson-rng
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v2:
> - Remove unrelated changes added by mistake. Suggested by Jason Gunthorpe.
>
> drivers/char/hw_random/meson-rng.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
> index 58bef39f7286..51864a509be7 100644
> --- a/drivers/char/hw_random/meson-rng.c
> +++ b/drivers/char/hw_random/meson-rng.c
> @@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
> { .compatible = "amlogic,meson-rng", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, meson_rng_of_match);
>
> static struct platform_driver meson_rng_driver = {
> .probe = meson_rng_probe,
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] hwrng: meson: Fix module autoload for OF registration
2016-10-17 19:51 [PATCH v2] hwrng: meson: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-19 9:19 ` Neil Armstrong
@ 2016-10-25 3:40 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2016-10-25 3:40 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Jason Gunthorpe, Kevin Hilman, Neil Armstrong,
PrasannaKumar Muralidharan, Carlo Caione, linux-amlogic,
Matt Mackall, linux-arm-kernel, linux-crypto
On Mon, Oct 17, 2016 at 04:51:17PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
> alias: platform:meson-rng
>
> After this patch:
>
> $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
> alias: platform:meson-rng
> alias: of:N*T*Camlogic,meson-rngC*
> alias: of:N*T*Camlogic,meson-rng
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-25 3:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 19:51 [PATCH v2] hwrng: meson: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-19 9:19 ` Neil Armstrong
2016-10-25 3:40 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox