From: Dave Jiang <dave.jiang@intel.com>
To: peng guo <engguopeng@buaa.edu.cn>,
dave@stgolabs.net, jonathan.cameron@huawei.com,
alison.schofield@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, dan.j.williams@intel.com
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
wyguopeng@163.com
Subject: Re: [PATCH] cxl core:wrong value of macro definition
Date: Mon, 8 Jul 2024 09:31:48 -0700 [thread overview]
Message-ID: <045fb08e-6d18-4558-b7b2-b83c412307da@intel.com> (raw)
In-Reply-To: <20240708152902.5853-1-engguopeng@buaa.edu.cn>
On 7/8/24 8:29 AM, peng guo wrote:
> The first value of the macro definition DEFINE_CXL_VENDOR_DEBUG_UUID
> does not match the definition in the CXL 2.0 specification table 170.
Thank you for the fix. Please use latest spec to identify. CXL spec r3.1 Table 8-71 I think?
Also, can you please provide a Fixes tag for this issue? Thanks!
>
> Signed-off-by: peng guo <engguopeng@buaa.edu.cn>
> ---
> drivers/cxl/cxlmem.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> index af8169ccdbc0..feb1106559d2 100644
> --- a/drivers/cxl/cxlmem.h
> +++ b/drivers/cxl/cxlmem.h
> @@ -563,7 +563,7 @@ enum cxl_opcode {
> 0x3b, 0x3f, 0x17)
>
> #define DEFINE_CXL_VENDOR_DEBUG_UUID \
> - UUID_INIT(0xe1819d9, 0x11a9, 0x400c, 0x81, 0x1f, 0xd6, 0x07, 0x19, \
> + UUID_INIT(0x5e1819d9, 0x11a9, 0x400c, 0x81, 0x1f, 0xd6, 0x07, 0x19, \
> 0x40, 0x3d, 0x86)
>
> struct cxl_mbox_get_supported_logs {
next prev parent reply other threads:[~2024-07-08 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 15:29 [PATCH] cxl core:wrong value of macro definition peng guo
2024-07-08 16:31 ` Dave Jiang [this message]
2024-07-09 14:12 ` [PATCH v2] cxl/core: Fix the UUID of CXL vendor debug Log identifier peng guo
2024-07-09 15:48 ` Dave Jiang
2024-07-09 18:33 ` Alison Schofield
2024-07-09 19:19 ` Dan Williams
2024-07-08 18:46 ` [PATCH] cxl core:wrong value of macro definition Alison Schofield
2024-07-10 0:07 ` peng guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=045fb08e-6d18-4558-b7b2-b83c412307da@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=engguopeng@buaa.edu.cn \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=wyguopeng@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox