From: Dan Williams <dan.j.williams@intel.com>
To: Alison Schofield <alison.schofield@intel.com>,
peng guo <engguopeng@buaa.edu.cn>
Cc: <dave@stgolabs.net>, <jonathan.cameron@huawei.com>,
<dave.jiang@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<wyguopeng@163.com>
Subject: Re: [PATCH v2] cxl/core: Fix the UUID of CXL vendor debug Log identifier
Date: Tue, 9 Jul 2024 12:19:06 -0700 [thread overview]
Message-ID: <668d8d2a96bfa_102cc29479@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <Zo2CjTCSnPmn6t8R@aschofie-mobl2>
Alison Schofield wrote:
> On Tue, Jul 09, 2024 at 10:12:39PM +0800, peng guo wrote:
> > Fix the definition value of DEFINE_CXL_VENDOR_DEBUG_UUID to match the
> > CXL r3.1 specification, although this value is not currently used.
>
> I thought the value was actually used.
> Please help me understand by responding to v1 review:
> https://lore.kernel.org/Zow0Aw+vrXShXv+n@aschofie-mobl2/
I assume that this was some "by inspection" reason for the "how found".
This effectively proves that no one has ever tried to use
CXL_MEM_COMMAND_ID_CLEAR_LOG with the vendor debug log. It could be the
case that everyone to date that ever had that need is just using RAW
commands to do it.
To me this is another example of Linux command wrapping CXL command
failure.
To your point though, it would be good to get that user visible effect
into the changelog so that distros can decide about the impact of
backporting this fix.
next prev parent reply other threads:[~2024-07-09 19:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 15:29 [PATCH] cxl core:wrong value of macro definition peng guo
2024-07-08 16:31 ` Dave Jiang
2024-07-09 14:12 ` [PATCH v2] cxl/core: Fix the UUID of CXL vendor debug Log identifier peng guo
2024-07-09 15:48 ` Dave Jiang
2024-07-09 18:33 ` Alison Schofield
2024-07-09 19:19 ` Dan Williams [this message]
2024-07-08 18:46 ` [PATCH] cxl core:wrong value of macro definition Alison Schofield
2024-07-10 0:07 ` peng guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=668d8d2a96bfa_102cc29479@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=engguopeng@buaa.edu.cn \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=wyguopeng@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox