Re: [PATCH v7 1/7] cxl/test: Add test for module parameters

[Dave Jiang <dave.jiang@intel.com>]

On 6/30/26 10:21 AM, Alison Schofield wrote:
> On Mon, Jun 29, 2026 at 03:10:58PM -0700, Dave Jiang wrote:
>> Add a test for module paraters during module init to make sure that
>> only one is activated.
>>
>> Suggested-by: Alison Schofield <alison.schofield@intel.com>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>> ---
>>  tools/testing/cxl/test/cxl.c       | 20 ++++++++++++++++++++
>>  tools/testing/cxl/test/hmem_test.c |  3 ++-
>>  tools/testing/cxl/test/mock.h      |  2 ++
>>  3 files changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
>> index ef92dd35e030..198a128181b9 100644
>> --- a/tools/testing/cxl/test/cxl.c
>> +++ b/tools/testing/cxl/test/cxl.c
>> @@ -1827,11 +1827,31 @@ static struct attribute *cxl_acpi_attrs[] = {
>>  };
>>  ATTRIBUTE_GROUPS(cxl_acpi);
>>  
>> +static bool __init have_multiple_modparms(void)
>> +{
>> +	int count = 0;
>> +
>> +	if (interleave_arithmetic)
>> +		count++;
>> +	if (extended_linear_cache)
>> +		count++;
>> +	if (fail_autoassemble)
>> +		count++;
>> +	if (hmem_test)
>> +		count++;
>> +
>> +	return count > 1;
>> +}
> 
> fail_autoassemble is a modifier of hmem_test, not a standalone mode.
> Needs to be dropped from above func for cxl-dax-hmem.sh to run.
> 
> Tested with this diff:
>  --- a/tools/testing/cxl/test/cxl.c
>   +++ b/tools/testing/cxl/test/cxl.c
>   @@ -2081,8 +2081,6 @@ static bool __init have_multiple_modparms(void)
>                 count++;
>         if (extended_linear_cache)
>                 count++;
>   -     if (fail_autoassemble)
>   -             count++;
>         if (hmem_test)
>                 count++;
>         if (type2_test)
> 

ok will drop