Re: [PATCH v7 7/7] cxl/test: Add cxl_test accelerator driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The function `cxl_set_capacity` is called but is neither declared nor defined anywhere in the kernel source.
--

commit e5897ac16ebf5251d0c169fc17ca2e8cde0dd51b
Author: Dave Jiang <dave.jiang@intel.com>

cxl/test: Add cxl_test accelerator driver

Add a type2 accelerator mock driver for the platform device that simulates
a CXL type2 device. The driver exercises the same minimal API calls that
a real CXL type2 driver would utilize.

> diff --git a/tools/testing/cxl/test/accel.c b/tools/testing/cxl/test/accel.c
> new file mode 100644
> index 0000000000000..8e6f4687ca02a
> --- /dev/null
> +++ b/tools/testing/cxl/test/accel.c
> @@ -0,0 +1,66 @@

[ ... ]

> +static int cxl_mock_accel_probe(struct platform_device *pdev)
> +{
> +	struct mock_cxl_accel *cxl_accel;
> +	struct device *dev = &pdev->dev;
> +	struct cxl_dev_state *cxlds;
> +	struct cxl_memdev *cxlmd;
> +	struct range mock_range;
> +	int rc;
> +
> +	cxl_accel = devm_cxl_dev_state_create(&pdev->dev, CXL_DEVTYPE_DEVMEM,
> +					      pdev->id + 1, 0,
> +					      struct mock_cxl_accel, cxlds,
> +					      false);
> +	if (!cxl_accel)
> +		return -ENOMEM;
> +
> +	cxlds = &cxl_accel->cxlds;
> +	cxlds->media_ready = true;
> +	rc = cxl_set_capacity(cxlds, SZ_512M);

[Severity: Low]
Is cxl_set_capacity() defined in a different patch in this series?

It appears this function is neither declared nor defined in the tree. Calling
an undeclared function here causes an implicit declaration error and a linker
failure, breaking the build when compiling the CXL mock test module.

> +	if (rc)
> +		return rc;
> +
> +	cxlmd = devm_cxl_probe_mem(cxlds, &mock_range);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629221104.3891733-1-dave.jiang@intel.com?part=7