From: alison.schofield@intel.com
To: Ben Widawsky <ben.widawsky@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
linux-cxl@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH v4 5/9] cxl/mbox: Remove dependency on cxl_mem_command for a debug msg
Date: Tue, 29 Mar 2022 18:30:20 -0700 [thread overview]
Message-ID: <1a1ebb7181b8be9fb746da48b41c02e54bee513e.1648601710.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1648601710.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
In preparation for removing access to struct cxl_mem_command,
change this debug message to use cxl_mbox_cmd fields instead.
Retrieve the pretty command name from cxl_mbox_cmd using a new
opcode to command name helper.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/cxl/core/mbox.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index 95882ab9f87b..654e61a77eb3 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -127,6 +127,17 @@ static struct cxl_mem_command *cxl_mem_find_command(u16 opcode)
return NULL;
}
+static const char *cxl_mem_opcode_to_name(u16 opcode)
+{
+ struct cxl_mem_command *c;
+
+ c = cxl_mem_find_command(opcode);
+ if (!c)
+ return NULL;
+
+ return cxl_command_names[c->info.id].name;
+}
+
/**
* cxl_mbox_send_cmd() - Send a mailbox command to a device.
* @cxlds: The device data for the operation
@@ -445,9 +456,9 @@ static int handle_mailbox_cmd_from_user(struct cxl_dev_state *cxlds,
dev_dbg(dev,
"Submitting %s command for user\n"
"\topcode: %x\n"
- "\tsize: %ub\n",
- cxl_command_names[cmd->info.id].name, mbox_cmd.opcode,
- cmd->info.size_in);
+ "\tsize: %zx\n",
+ cxl_mem_opcode_to_name(mbox_cmd.opcode),
+ mbox_cmd.opcode, mbox_cmd.size_in);
rc = cxlds->mbox_send(cxlds, &mbox_cmd);
if (rc)
--
2.31.1
next prev parent reply other threads:[~2022-03-30 1:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 1:30 [PATCH v4 0/9] Do not allow set-partition immediate mode alison.schofield
2022-03-30 1:30 ` [PATCH v4 1/9] cxl/mbox: Move cxl_mem_command construction to helper funcs alison.schofield
2022-03-30 3:23 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 2/9] cxl/mbox: Move raw command warning to raw command validation alison.schofield
2022-03-30 3:24 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 3/9] cxl/mbox: Move build of user mailbox cmd to a helper function alison.schofield
2022-03-30 3:29 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 4/9] cxl/mbox: Construct a users cxl_mbox_cmd in the validation path alison.schofield
2022-03-30 4:39 ` Dan Williams
2022-03-30 1:30 ` alison.schofield [this message]
2022-03-30 4:50 ` [PATCH v4 5/9] cxl/mbox: Remove dependency on cxl_mem_command for a debug msg Dan Williams
2022-03-30 19:14 ` Alison Schofield
2022-03-30 1:30 ` [PATCH v4 6/9] cxl/mbox: Make handle_mailbox_cmd_from_user() use a mbox param alison.schofield
2022-03-30 5:00 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 7/9] cxl/mbox: Move cxl_mem_command param to a local variable alison.schofield
2022-03-30 1:30 ` [PATCH v4 8/9] cxl/mbox: Block immediate mode in SET_PARTITION_INFO command alison.schofield
2022-03-30 1:30 ` [PATCH v4 9/9] cxl/pmem: Remove CXL SET_PARTITION_INFO from exclusive_cmds list alison.schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a1ebb7181b8be9fb746da48b41c02e54bee513e.1648601710.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox