From: Alison Schofield <alison.schofield@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Ben Widawsky <ben.widawsky@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
linux-cxl@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v4 5/9] cxl/mbox: Remove dependency on cxl_mem_command for a debug msg
Date: Wed, 30 Mar 2022 12:14:54 -0700 [thread overview]
Message-ID: <20220330191454.GA1177056@alison-desk> (raw)
In-Reply-To: <CAPcyv4gaZsFQYnFQtWBni67NYLoBxN+Hc=Y96OtPTPu5sRXfnA@mail.gmail.com>
On Tue, Mar 29, 2022 at 09:50:17PM -0700, Dan Williams wrote:
> On Tue, Mar 29, 2022 at 6:28 PM <alison.schofield@intel.com> wrote:
snip
> >
> > dev_dbg(dev,
> > "Submitting %s command for user\n"
> > "\topcode: %x\n"
> > - "\tsize: %ub\n",
> > - cxl_command_names[cmd->info.id].name, mbox_cmd.opcode,
> > - cmd->info.size_in);
> > + "\tsize: %zx\n",
> > + cxl_mem_opcode_to_name(mbox_cmd.opcode),
> > + mbox_cmd.opcode, mbox_cmd.size_in);
>
> Looks ok, although it's just a debug statement so the raw opcode would
> also be acceptable to me to meet the goal of dropping the
> cxl_mem_command usage.
I thought the opcode_to_name helper might be overkill, until
it came in handy in a later patch. It gets used again to find
the command name when a payload is not allowed.
>
> Either way you decide to go:
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2022-03-30 19:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 1:30 [PATCH v4 0/9] Do not allow set-partition immediate mode alison.schofield
2022-03-30 1:30 ` [PATCH v4 1/9] cxl/mbox: Move cxl_mem_command construction to helper funcs alison.schofield
2022-03-30 3:23 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 2/9] cxl/mbox: Move raw command warning to raw command validation alison.schofield
2022-03-30 3:24 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 3/9] cxl/mbox: Move build of user mailbox cmd to a helper function alison.schofield
2022-03-30 3:29 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 4/9] cxl/mbox: Construct a users cxl_mbox_cmd in the validation path alison.schofield
2022-03-30 4:39 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 5/9] cxl/mbox: Remove dependency on cxl_mem_command for a debug msg alison.schofield
2022-03-30 4:50 ` Dan Williams
2022-03-30 19:14 ` Alison Schofield [this message]
2022-03-30 1:30 ` [PATCH v4 6/9] cxl/mbox: Make handle_mailbox_cmd_from_user() use a mbox param alison.schofield
2022-03-30 5:00 ` Dan Williams
2022-03-30 1:30 ` [PATCH v4 7/9] cxl/mbox: Move cxl_mem_command param to a local variable alison.schofield
2022-03-30 1:30 ` [PATCH v4 8/9] cxl/mbox: Block immediate mode in SET_PARTITION_INFO command alison.schofield
2022-03-30 1:30 ` [PATCH v4 9/9] cxl/pmem: Remove CXL SET_PARTITION_INFO from exclusive_cmds list alison.schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330191454.GA1177056@alison-desk \
--to=alison.schofield@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox