Re: [PATCH 1/2] cxl: Move command enumeration from dev_dbg() to traceevent

[Dave Jiang <dave.jiang@intel.com>]

On 9/15/23 15:11, Ira Weiny wrote:
> Dave Jiang wrote:
>> Given that event logs outputs are all emitted to traceevent, move the
>> enumeration of log types to traceevent as well in order to keep all the
>> outputs at the same location.
>>
>> Suggested-by: Alison Schofield <alison.schofield@intel.com>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> 
> My gut reaction was to nak this patch because I'm not sure how to enable
> trace events prior to module load.  Then I realized that this is in the
> cxl_core and is only triggered by driver loads.  So I've not tested this
> patch but I think the following sequence will work for these 2 patches.
> 
> $ modprobe cxl_core
> $ echo 1 > /sys/kernel/tracing/events/cxl/cxl_log_type/enable
> $ modprobe cxl_pci

I don't see any other way to do this. I saw this [1] but it doesn't appeared to be upstream.

[1]: https://lwn.net/Articles/432186/

> 
> Is that how you tested this?  It seems like a pain.  But perhaps that pain
> is fine because these debug messages are not as useful as others?
> Especially for all the unsupported messages mentioned in patch 2?

Yes. Alison mentioned seeing maybe 500+ of those.

> 
> Ira