From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>
Cc: <dave@stgolabs.net>, <jonathan.cameron@huawei.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>
Subject: Re: [PATCH 1/2] cxl: Move command enumeration from dev_dbg() to traceevent
Date: Fri, 15 Sep 2023 15:11:38 -0700 [thread overview]
Message-ID: <6504d69a10453_37d9bb294a1@iweiny-mobl.notmuch> (raw)
In-Reply-To: <169480882977.2690926.2796694282356938267.stgit@djiang5-mobl3>
Dave Jiang wrote:
> Given that event logs outputs are all emitted to traceevent, move the
> enumeration of log types to traceevent as well in order to keep all the
> outputs at the same location.
>
> Suggested-by: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
My gut reaction was to nak this patch because I'm not sure how to enable
trace events prior to module load. Then I realized that this is in the
cxl_core and is only triggered by driver loads. So I've not tested this
patch but I think the following sequence will work for these 2 patches.
$ modprobe cxl_core
$ echo 1 > /sys/kernel/tracing/events/cxl/cxl_log_type/enable
$ modprobe cxl_pci
Is that how you tested this? It seems like a pain. But perhaps that pain
is fine because these debug messages are not as useful as others?
Especially for all the unsupported messages mentioned in patch 2?
Ira
next prev parent reply other threads:[~2023-09-15 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 20:13 [PATCH 1/2] cxl: Move command enumeration from dev_dbg() to traceevent Dave Jiang
2023-09-15 20:13 ` [PATCH 2/2] cxl: Move opcode reporting " Dave Jiang
2023-09-18 16:51 ` Alison Schofield
2023-09-18 21:25 ` Ira Weiny
2023-09-15 22:11 ` Ira Weiny [this message]
2023-09-15 22:49 ` [PATCH 1/2] cxl: Move command enumeration " Dave Jiang
2023-09-18 17:49 ` Ira Weiny
2023-09-18 18:21 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6504d69a10453_37d9bb294a1@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox