From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: <linux-cxl@vger.kernel.org>,
Ben Widawsky <ben.widawsky@intel.com>,
<alison.schofield@intel.com>
Subject: Re: [PATCH 4/6] cxl/uapi: Fix defined but not used warnings
Date: Mon, 6 Sep 2021 10:05:25 +0100 [thread overview]
Message-ID: <20210906100525.00007727@Huawei.com> (raw)
In-Reply-To: <163072205652.2250120.16833548560832424468.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, 3 Sep 2021 19:20:56 -0700
Dan Williams <dan.j.williams@intel.com> wrote:
> From: Ben Widawsky <ben.widawsky@intel.com>
>
> Fix unused-const-variable warnings emitted by gcc when cxlmem.h is used
> by pretty much all files except pci.c
>
> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
FWIW another obviously correct one.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> include/uapi/linux/cxl_mem.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
> index f6e8a005b113..8d206f27bb6d 100644
> --- a/include/uapi/linux/cxl_mem.h
> +++ b/include/uapi/linux/cxl_mem.h
> @@ -50,7 +50,7 @@ enum { CXL_CMDS };
> #define ___C(a, b) { b }
> static const struct {
> const char *name;
> -} cxl_command_names[] = { CXL_CMDS };
> +} cxl_command_names[] __attribute__((__unused__)) = { CXL_CMDS };
>
> /*
> * Here's how this actually breaks out:
>
next prev parent reply other threads:[~2021-09-06 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 2:20 [PATCH 0/6] cxl fixes for v5.15-rc1 Dan Williams
2021-09-04 2:20 ` [PATCH 1/6] cxl/acpi: Do not add DSDT disabled ACPI0016 host bridge ports Dan Williams
2021-09-04 2:20 ` [PATCH 2/6] cxl/pci: Fix lockdown level Dan Williams
2021-09-04 3:57 ` Paul Moore
2021-09-07 17:38 ` Dan Williams
2021-09-07 19:46 ` Paul Moore
2021-09-10 12:55 ` Ondrej Mosnacek
2021-09-10 14:56 ` Dan Williams
2021-09-10 17:46 ` Paul Moore
2021-09-04 2:20 ` [PATCH 3/6] cxl/pci: Fix debug message in cxl_probe_regs() Dan Williams
2021-09-06 9:04 ` Jonathan Cameron
2021-09-04 2:20 ` [PATCH 4/6] cxl/uapi: Fix defined but not used warnings Dan Williams
2021-09-06 9:05 ` Jonathan Cameron [this message]
2021-09-04 2:21 ` [PATCH 5/6] cxl/pmem: Fix Documentation warning Dan Williams
2021-09-06 9:08 ` Jonathan Cameron
2021-09-04 2:21 ` [PATCH 6/6] cxl/registers: " Dan Williams
2021-09-06 9:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906100525.00007727@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox