Linux CXL
 help / color / mirror / Atom feed
* [PATCH] cxl/memdev: Remove unused cxlmd field
@ 2021-11-03 23:48 ira.weiny
  2021-11-04  9:37 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: ira.weiny @ 2021-11-03 23:48 UTC (permalink / raw)
  To: Dan Williams
  Cc: Ira Weiny, Jonathan.Cameron, Alison Schofield, Vishal Verma,
	Ben Widawsky, linux-cxl

From: Ira Weiny <ira.weiny@intel.com>

This field was left over when the connection between the cxl_memdev and
cxl_mem was tighter.  It is no longer set nor used so remove it.[1]

[1] https://lore.kernel.org/linux-cxl/CAPcyv4hcgh2gb8qsS_UXTBSGqYfMPnC6p5kkvNUjm+V6kVKM5g@mail.gmail.com/

Suggested-by: Jonathan.Cameron@huawei.com
Signed-off-by: Ira Weiny <ira.weiny@intel.com>

---
Changes from V1:
	Change Subject

[v1] https://lore.kernel.org/linux-cxl/20211103223413.n6fmf3gtop56wssz@intel.com/T/#m79c2c7ba4cc897c10e26acdaca890887e1dd487f
---
 drivers/cxl/cxlmem.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
index f978a046591b..8d96d009ad90 100644
--- a/drivers/cxl/cxlmem.h
+++ b/drivers/cxl/cxlmem.h
@@ -97,7 +97,6 @@ struct cxl_mbox_cmd {
  * Currently only memory devices are represented.
  *
  * @dev: The device associated with this CXL state
- * @cxlmd: Logical memory device chardev / interface
  * @regs: Parsed register blocks
  * @payload_size: Size of space for payload
  *                (CXL 2.0 8.2.8.4.3 Mailbox Capabilities Register)
@@ -124,7 +123,6 @@ struct cxl_mbox_cmd {
  */
 struct cxl_dev_state {
 	struct device *dev;
-	struct cxl_memdev *cxlmd;
 
 	struct cxl_regs regs;
 
-- 
2.28.0.rc0.12.gb6a658bd00c9


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cxl/memdev: Remove unused cxlmd field
  2021-11-03 23:48 [PATCH] cxl/memdev: Remove unused cxlmd field ira.weiny
@ 2021-11-04  9:37 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-11-04  9:37 UTC (permalink / raw)
  To: ira.weiny
  Cc: Dan Williams, Alison Schofield, Vishal Verma, Ben Widawsky,
	linux-cxl

On Wed, 3 Nov 2021 16:48:57 -0700
<ira.weiny@intel.com> wrote:

> From: Ira Weiny <ira.weiny@intel.com>
> 
> This field was left over when the connection between the cxl_memdev and
> cxl_mem was tighter.  It is no longer set nor used so remove it.[1]
> 
> [1] https://lore.kernel.org/linux-cxl/CAPcyv4hcgh2gb8qsS_UXTBSGqYfMPnC6p5kkvNUjm+V6kVKM5g@mail.gmail.com/
> 
> Suggested-by: Jonathan.Cameron@huawei.com
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> 
> ---
> Changes from V1:
> 	Change Subject
> 
> [v1] https://lore.kernel.org/linux-cxl/20211103223413.n6fmf3gtop56wssz@intel.com/T/#m79c2c7ba4cc897c10e26acdaca890887e1dd487f
> ---
>  drivers/cxl/cxlmem.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> index f978a046591b..8d96d009ad90 100644
> --- a/drivers/cxl/cxlmem.h
> +++ b/drivers/cxl/cxlmem.h
> @@ -97,7 +97,6 @@ struct cxl_mbox_cmd {
>   * Currently only memory devices are represented.
>   *
>   * @dev: The device associated with this CXL state
> - * @cxlmd: Logical memory device chardev / interface
>   * @regs: Parsed register blocks
>   * @payload_size: Size of space for payload
>   *                (CXL 2.0 8.2.8.4.3 Mailbox Capabilities Register)
> @@ -124,7 +123,6 @@ struct cxl_mbox_cmd {
>   */
>  struct cxl_dev_state {
>  	struct device *dev;
> -	struct cxl_memdev *cxlmd;
>  
>  	struct cxl_regs regs;
>  


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-04  9:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-03 23:48 [PATCH] cxl/memdev: Remove unused cxlmd field ira.weiny
2021-11-04  9:37 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox