From: Alison Schofield <alison.schofield@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org, kernel test robot <lkp@intel.com>,
nvdimm@lists.linux.dev
Subject: Re: [PATCH] memregion: Fix memregion_free() fallback definition
Date: Thu, 23 Jun 2022 16:56:54 -0700 [thread overview]
Message-ID: <20220623235654.GA1557841@alison-desk> (raw)
In-Reply-To: <165601455171.4042645.3350844271068713515.stgit@dwillia2-xfh>
On Thu, Jun 23, 2022 at 01:02:31PM -0700, Dan Williams wrote:
> In the CONFIG_MEMREGION=n case, memregion_free() is meant to be a static
> inline. 0day reports:
>
> In file included from drivers/cxl/core/port.c:4:
> include/linux/memregion.h:19:6: warning: no previous prototype for
> function 'memregion_free' [-Wmissing-prototypes]
>
> Mark memregion_free() static.
>
> Fixes: 33dd70752cd7 ("lib: Uplevel the pmem "region" ida to a global allocator")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> ---
> include/linux/memregion.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memregion.h b/include/linux/memregion.h
> index e11595256cac..c04c4fd2e209 100644
> --- a/include/linux/memregion.h
> +++ b/include/linux/memregion.h
> @@ -16,7 +16,7 @@ static inline int memregion_alloc(gfp_t gfp)
> {
> return -ENOMEM;
> }
> -void memregion_free(int id)
> +static inline void memregion_free(int id)
> {
> }
> #endif
>
>
prev parent reply other threads:[~2022-06-23 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 20:02 [PATCH] memregion: Fix memregion_free() fallback definition Dan Williams
2022-06-23 23:56 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623235654.GA1557841@alison-desk \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox