* [PATCH] memregion: Fix memregion_free() fallback definition
@ 2022-06-23 20:02 Dan Williams
2022-06-23 23:56 ` Alison Schofield
0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2022-06-23 20:02 UTC (permalink / raw)
To: linux-cxl; +Cc: kernel test robot, nvdimm
In the CONFIG_MEMREGION=n case, memregion_free() is meant to be a static
inline. 0day reports:
In file included from drivers/cxl/core/port.c:4:
include/linux/memregion.h:19:6: warning: no previous prototype for
function 'memregion_free' [-Wmissing-prototypes]
Mark memregion_free() static.
Fixes: 33dd70752cd7 ("lib: Uplevel the pmem "region" ida to a global allocator")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
include/linux/memregion.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/memregion.h b/include/linux/memregion.h
index e11595256cac..c04c4fd2e209 100644
--- a/include/linux/memregion.h
+++ b/include/linux/memregion.h
@@ -16,7 +16,7 @@ static inline int memregion_alloc(gfp_t gfp)
{
return -ENOMEM;
}
-void memregion_free(int id)
+static inline void memregion_free(int id)
{
}
#endif
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] memregion: Fix memregion_free() fallback definition
2022-06-23 20:02 [PATCH] memregion: Fix memregion_free() fallback definition Dan Williams
@ 2022-06-23 23:56 ` Alison Schofield
0 siblings, 0 replies; 2+ messages in thread
From: Alison Schofield @ 2022-06-23 23:56 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-cxl, kernel test robot, nvdimm
On Thu, Jun 23, 2022 at 01:02:31PM -0700, Dan Williams wrote:
> In the CONFIG_MEMREGION=n case, memregion_free() is meant to be a static
> inline. 0day reports:
>
> In file included from drivers/cxl/core/port.c:4:
> include/linux/memregion.h:19:6: warning: no previous prototype for
> function 'memregion_free' [-Wmissing-prototypes]
>
> Mark memregion_free() static.
>
> Fixes: 33dd70752cd7 ("lib: Uplevel the pmem "region" ida to a global allocator")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> ---
> include/linux/memregion.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memregion.h b/include/linux/memregion.h
> index e11595256cac..c04c4fd2e209 100644
> --- a/include/linux/memregion.h
> +++ b/include/linux/memregion.h
> @@ -16,7 +16,7 @@ static inline int memregion_alloc(gfp_t gfp)
> {
> return -ENOMEM;
> }
> -void memregion_free(int id)
> +static inline void memregion_free(int id)
> {
> }
> #endif
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-23 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-23 20:02 [PATCH] memregion: Fix memregion_free() fallback definition Dan Williams
2022-06-23 23:56 ` Alison Schofield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox