Linux CXL
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
	dan.j.williams@intel.com, ira.weiny@intel.com,
	vishal.l.verma@intel.com, alison.schofield@intel.com,
	Jonathan.Cameron@huawei.com
Subject: Re: [PATCH v7 18/20] cxl: bypass cpu_cache_invalidate_memregion() when in test config
Date: Wed, 30 Nov 2022 14:16:41 -0800	[thread overview]
Message-ID: <20221130221641.hban57icdww2fie5@offworld> (raw)
In-Reply-To: <166983619332.2734609.2800078343178136915.stgit@djiang5-desk3.ch.intel.com>

On Wed, 30 Nov 2022, Dave Jiang wrote:

>Bypass cpu_cache_invalidate_memregion() and checks when doing testing
>using CONFIG_NVDIMM_SECURITY_TEST flag. The bypass allows testing on
>QEMU where cpu_cache_has_invalidate_memregion() fails. Usage of
>cpu_cache_invalidate_memregion() is not needed for cxl_test security
>testing.

We'll also want something similar for the non-pmem specific security
bits by extending these wrappers with CONFIG_CXL_SECURITY_TEST. I
think the current naming is very generic but the functionality is
too tied to pmem. So I would either rename these to 'cxl_pmem...'
or make them more generic by placing them in cxlmem.h and taking the
dev pointer directly as well as the iores.

Thanks,
Davidlohr

  reply	other threads:[~2022-11-30 22:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 19:21 [PATCH v7 00/20] Introduce security commands for CXL pmem device Dave Jiang
2022-11-30 19:21 ` [PATCH v7 01/20] cxl/pmem: Introduce nvdimm_security_ops with ->get_flags() operation Dave Jiang
2023-02-28 15:09   ` Jonathan Cameron
2023-03-01 23:06     ` [PATCH] cxl: fix compile warning for cxl_security_ops extern Dave Jiang
2023-03-02  0:17       ` Alison Schofield
2023-08-16 18:07         ` Alison Schofield
2023-03-03 12:15       ` Jonathan Cameron
2023-08-04 18:02       ` Alison Schofield
2022-11-30 19:21 ` [PATCH v7 02/20] tools/testing/cxl: Add "Get Security State" opcode support Dave Jiang
2022-11-30 19:21 ` [PATCH v7 03/20] cxl/pmem: Add "Set Passphrase" security command support Dave Jiang
2022-11-30 19:21 ` [PATCH v7 04/20] tools/testing/cxl: Add "Set Passphrase" opcode support Dave Jiang
2022-11-30 19:21 ` [PATCH v7 05/20] cxl/pmem: Add Disable Passphrase security command support Dave Jiang
2022-11-30 19:22 ` [PATCH v7 06/20] tools/testing/cxl: Add "Disable" security opcode support Dave Jiang
2022-11-30 19:22 ` [PATCH v7 07/20] cxl/pmem: Add "Freeze Security State" security command support Dave Jiang
2022-11-30 19:22 ` [PATCH v7 08/20] tools/testing/cxl: Add "Freeze Security State" security opcode support Dave Jiang
2022-11-30 19:22 ` [PATCH v7 09/20] cxl/pmem: Add "Unlock" security command support Dave Jiang
2022-11-30 19:22 ` [PATCH v7 10/20] tools/testing/cxl: Add "Unlock" security opcode support Dave Jiang
2022-11-30 19:22 ` [PATCH v7 11/20] cxl/pmem: Add "Passphrase Secure Erase" security command support Dave Jiang
2022-11-30 19:22 ` [PATCH v7 12/20] tools/testing/cxl: Add "passphrase secure erase" opcode support Dave Jiang
2022-11-30 19:22 ` [PATCH v7 13/20] nvdimm/cxl/pmem: Add support for master passphrase disable security command Dave Jiang
2022-11-30 19:22 ` [PATCH v7 14/20] cxl/pmem: add id attribute to CXL based nvdimm Dave Jiang
2022-11-30 19:22 ` [PATCH v7 15/20] tools/testing/cxl: add mechanism to lock mem device for testing Dave Jiang
2022-11-30 19:23 ` [PATCH v7 16/20] cxl/pmem: add provider name to cxl pmem dimm attribute group Dave Jiang
2022-11-30 19:23 ` [PATCH v7 17/20] libnvdimm: Introduce CONFIG_NVDIMM_SECURITY_TEST flag Dave Jiang
2022-11-30 19:23 ` [PATCH v7 18/20] cxl: bypass cpu_cache_invalidate_memregion() when in test config Dave Jiang
2022-11-30 22:16   ` Davidlohr Bueso [this message]
2022-11-30 23:54     ` Dan Williams
2022-12-01  1:51       ` Davidlohr Bueso
2022-12-01  3:05         ` Dan Williams
2022-12-01 11:11   ` Jonathan Cameron
2022-11-30 19:23 ` [PATCH v7 19/20] acpi/nfit: " Dave Jiang
2022-12-01 11:22   ` Jonathan Cameron
2022-11-30 19:23 ` [PATCH v7 20/20] cxl: add dimm_id support for __nvdimm_create() Dave Jiang
2022-12-01  2:20   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221130221641.hban57icdww2fie5@offworld \
    --to=dave@stgolabs.net \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox