* [PATCH v2] cxl/region: Only warn about cpu_cache_invalidate_memregion() once
@ 2022-12-15 18:38 Davidlohr Bueso
2022-12-15 19:21 ` Dave Jiang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2022-12-15 18:38 UTC (permalink / raw)
To: dan.j.williams; +Cc: dave.jiang, mcgrof, linux-cxl, dave
No need for more than once per region.
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
drivers/cxl/core/region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index 02f28da519e3..c11a6ab5e48d 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -1967,7 +1967,7 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
if (!cpu_cache_has_invalidate_memregion()) {
if (IS_ENABLED(CONFIG_CXL_REGION_INVALIDATION_TEST)) {
- dev_warn(
+ dev_warn_once(
&cxlr->dev,
"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] cxl/region: Only warn about cpu_cache_invalidate_memregion() once
2022-12-15 18:38 [PATCH v2] cxl/region: Only warn about cpu_cache_invalidate_memregion() once Davidlohr Bueso
@ 2022-12-15 19:21 ` Dave Jiang
2022-12-16 11:15 ` Jonathan Cameron
2022-12-16 17:31 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2022-12-15 19:21 UTC (permalink / raw)
To: Davidlohr Bueso, dan.j.williams; +Cc: mcgrof, linux-cxl
On 12/15/2022 11:38 AM, Davidlohr Bueso wrote:
> No need for more than once per region.
>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/cxl/core/region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index 02f28da519e3..c11a6ab5e48d 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -1967,7 +1967,7 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
>
> if (!cpu_cache_has_invalidate_memregion()) {
> if (IS_ENABLED(CONFIG_CXL_REGION_INVALIDATION_TEST)) {
> - dev_warn(
> + dev_warn_once(
> &cxlr->dev,
> "Bypassing cpu_cache_invalidate_memregion() for testing!\n");
> clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] cxl/region: Only warn about cpu_cache_invalidate_memregion() once
2022-12-15 18:38 [PATCH v2] cxl/region: Only warn about cpu_cache_invalidate_memregion() once Davidlohr Bueso
2022-12-15 19:21 ` Dave Jiang
@ 2022-12-16 11:15 ` Jonathan Cameron
2022-12-16 17:31 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2022-12-16 11:15 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: dan.j.williams, dave.jiang, mcgrof, linux-cxl
On Thu, 15 Dec 2022 10:38:36 -0800
Davidlohr Bueso <dave@stgolabs.net> wrote:
> No need for more than once per region.
>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> drivers/cxl/core/region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index 02f28da519e3..c11a6ab5e48d 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -1967,7 +1967,7 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
>
> if (!cpu_cache_has_invalidate_memregion()) {
> if (IS_ENABLED(CONFIG_CXL_REGION_INVALIDATION_TEST)) {
> - dev_warn(
> + dev_warn_once(
> &cxlr->dev,
> "Bypassing cpu_cache_invalidate_memregion() for testing!\n");
> clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
Seems sensible.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH v2] cxl/region: Only warn about cpu_cache_invalidate_memregion() once
2022-12-15 18:38 [PATCH v2] cxl/region: Only warn about cpu_cache_invalidate_memregion() once Davidlohr Bueso
2022-12-15 19:21 ` Dave Jiang
2022-12-16 11:15 ` Jonathan Cameron
@ 2022-12-16 17:31 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2022-12-16 17:31 UTC (permalink / raw)
To: Davidlohr Bueso, dan.j.williams; +Cc: dave.jiang, mcgrof, linux-cxl, dave
Davidlohr Bueso wrote:
> No need for more than once per region.
Applied with this fixed up:
s/per region/per module load/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-16 17:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 18:38 [PATCH v2] cxl/region: Only warn about cpu_cache_invalidate_memregion() once Davidlohr Bueso
2022-12-15 19:21 ` Dave Jiang
2022-12-16 11:15 ` Jonathan Cameron
2022-12-16 17:31 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox