Re: [RFC PATCH 3/8] cxl: refactor cxl_hdm_decode_init()

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Wed, 30 Nov 2022 16:12:32 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> With the previous refactoring of DVSEC range registers out of
> cxl_hdm_decode_init(), it basically becomes a skeleton function. Squash
> __cxl_hdm_decode_init() with cxl_hdm_decode_init() to simplify the code.

Should mention briefly that this results in richer (i.e. not all -EBUSY)
error return codes.  One other trivial suggestion below that might well
become irrelevant in later patches.


> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>

> @@ -445,17 +370,68 @@ int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm,
>  {

...

> +	rc = devm_cxl_enable_mem(&port->dev, cxlds);
> +	if (rc)
> +		return rc;
> +
>  	return 0;
	return dev_cxl_enable_mem()
assuming this doesn't then need putting back as it is in later patches becasue
you add more stuff before the return 0.

>  }
>  EXPORT_SYMBOL_NS_GPL(cxl_hdm_decode_init, CXL);
> 
>