Re: [RFC PATCH 7/8] cxl: suppress component register discovery failure warning for RCD

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Wed, 30 Nov 2022 16:12:55 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> For an RCD, it is expected that component register won't be discovered by
> cxl_pci. Suppress warning if RCD.

I've lost track a bit on where this ended up in the RCD series
but from a spec point of view 8.2.2 in CXL 3.0 makes it clear
that it's fine for component registers to be in a BAR and hence
the register block locator.  Hence does the "expected" want relaxing
to an "allowed" or even "likely".  Expected kind of implies the
opposite isn't expected.

> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/pci.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 73ff6c33a0c0..d808da838909 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -486,7 +486,7 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	 */
>  	cxlds->component_reg_phys = CXL_RESOURCE_NONE;
>  	rc = cxl_setup_regs(pdev, CXL_REGLOC_RBI_COMPONENT, &map);
> -	if (rc)
> +	if (rc && !cxlds->rcd)
>  		dev_warn(&pdev->dev, "No component registers (%d)\n", rc);
>  
>  	cxlds->component_reg_phys = cxl_regmap_to_base(pdev, &map);
> 
>