Re: [GIT preview] for-6.3/cxl-ram-region

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Wed, 25 Jan 2023 22:29:15 -0800
Dan Williams <dan.j.williams@intel.com> wrote:

> Dan Williams wrote:
> > There are still some sharp edges on this patchset, like the missing
> > device-dax hookup, but it is likely enough to show the direction and
> > unblock other testing. Specifically I want to see how this fares with
> > Greg's recent volatile region provisioning in QEMU.
> > 
> > I am hoping to have those last bits ironed out before the end of the
> > week. Note that this topic branch will rebase so do not base any
> > work beyond proof-of-concept on top of it.
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git/log/?h=for-6.3/cxl-ram-region  
> 
> I also spotted at least one bug-fix that needs to be broken out and
> submitted separately, so reviewer-beware at this stage.

So far I'm failing to set target0 via echo which is wonderfully getting
an error of SUCCESS.  So I think you are returning rc == 0 somewhere.


Ah. There is a shadowed int rc variable in store_targetN() else

Now to figure out why attach_target() is failing.  I probably have
the config sequence wrong as I've just bodged an existing one I had
for pmem.

Jonathan