Re: [PATCH] cxl/pci: Set the device timestamp

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

> > >  /*
> > > @@ -857,6 +859,29 @@ int cxl_mem_create_range_info(struct cxl_dev_state *cxlds)
> > >  }
> > >  EXPORT_SYMBOL_NS_GPL(cxl_mem_create_range_info, CXL);
> > >  
> > > +int cxl_set_timestamp(struct cxl_dev_state *cxlds, u64 ts)
> > > +{
> > > +	struct cxl_mbox_cmd mbox_cmd;
> > > +	struct cxl_mbox_set_timestamp_in pi;
> > > +
> > > +	/*
> > > +	 * Command is optional and functionality should not be affected if
> > > +	 * the command is not available.
> > > +	 */
> > > +	if (!test_bit(CXL_MEM_COMMAND_ID_SET_TIMESTAMP, cxlds->enabled_cmds))
> > > +		return 0;

One side effect of dropping the userspace handling is we loose
the presence in enabled_cmds (based on the CEL).  I've replaced
this with specific handling of the Not Supported mailbox return code
and suitable comments on why I'm not considering that an error.

Hopefully that compromise makes sense.

Jonathan