From: Davidlohr Bueso <dave@stgolabs.net>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: dan.j.williams@intel.com, ira.weiny@intel.com,
fan.ni@samsung.com, a.manzanares@samsung.com,
linux-cxl@vger.kernel.org
Subject: Re: [PATCH 1/3] cxl/mbox: Add support for background operations
Date: Fri, 7 Apr 2023 11:05:12 -0700 [thread overview]
Message-ID: <20230407180512.pj2lznudcidb7f7l@offworld> (raw)
In-Reply-To: <20230403174730.00003920@Huawei.com>
On Mon, 03 Apr 2023, Jonathan Cameron wrote:
>> @@ -350,7 +350,14 @@ static CXLRetCode cmd_infostat_bg_op_sts(struct cxl_cmd *cmd,
>>
>> bg_op_status = (void *)cmd->payload;
>> memset(bg_op_status, 0, sizeof(*bg_op_status));
>> - /* No support yet for background operations so status all 0 */
>> + bg_op_status->status = ARRAY_FIELD_EX64(cxl_dstate->mbox_reg_state64,
>> + CXL_DEV_BG_CMD_STS, PERCENTAGE_COMP) << 1;
>
>Ah. I'd forgotten I bodged this one in for the switch.
General question, do you know the reasoning behind why this command is only listed
for switches (while the overall vocabulary is very generic to all bg-capable commands)?
Thanks,
Davidlohr
next prev parent reply other threads:[~2023-04-07 18:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 19:44 [PATCH -qemu 0/3] cxl: Background commands and device sanitation Davidlohr Bueso
2023-02-24 19:44 ` [PATCH 1/3] cxl/mbox: Add support for background operations Davidlohr Bueso
2023-03-01 19:00 ` Fan Ni
2023-03-01 20:45 ` Davidlohr Bueso
2023-04-03 16:47 ` Jonathan Cameron
2023-04-07 18:05 ` Davidlohr Bueso [this message]
2023-04-14 13:49 ` Jonathan Cameron
2023-04-11 19:06 ` Davidlohr Bueso
2023-04-14 13:51 ` Jonathan Cameron
2023-02-24 19:44 ` [PATCH 2/3] cxl/mbox: Wire up interrupts for background completion Davidlohr Bueso
2023-04-03 16:52 ` Jonathan Cameron
2023-04-04 9:22 ` Jonathan Cameron
2023-04-12 2:22 ` Davidlohr Bueso
2023-04-14 13:43 ` Jonathan Cameron
2023-02-24 19:44 ` [PATCH 3/3] cxl: Add support for device sanitation Davidlohr Bueso
2023-04-14 14:15 ` Jonathan Cameron
2023-04-16 2:32 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407180512.pj2lznudcidb7f7l@offworld \
--to=dave@stgolabs.net \
--cc=Jonathan.Cameron@Huawei.com \
--cc=a.manzanares@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox