From: Ira Weiny <ira.weiny@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: "Jiang, Dave" <dave.jiang@intel.com>,
"Schofield, Alison" <alison.schofield@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
Ira Weiny <ira.weiny@intel.com>
Subject: [PATCH ndctl] ndctl/cxl/test: Add CXL event test
Date: Thu, 27 Jul 2023 14:21:09 -0700 [thread overview]
Message-ID: <20230726-cxl-event-v1-1-1cf8cb02b211@intel.com> (raw)
Previously CXL event testing was run by hand. This reduces testing
coverage including a lack of regression testing.
Add a CXL test as part of the meson test infrastructure. Passing is
predicated on receiving the appropriate number of errors in each log.
Individual event values are not checked.
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
test/cxl-events.sh | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
test/meson.build | 2 ++
2 files changed, 70 insertions(+)
diff --git a/test/cxl-events.sh b/test/cxl-events.sh
new file mode 100644
index 000000000000..f51046ec39ad
--- /dev/null
+++ b/test/cxl-events.sh
@@ -0,0 +1,68 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2023 Intel Corporation. All rights reserved.
+
+. $(dirname $0)/common
+
+set -ex
+
+trap 'err $LINENO' ERR
+
+check_prereq "jq"
+
+modprobe -r cxl_test
+modprobe cxl_test
+
+dev_path="/sys/bus/platform/devices"
+
+test_cxl_events()
+{
+ memdev="$1"
+
+ echo "TEST: triggering $memdev"
+ echo 1 > $dev_path/$memdev/event_trigger
+}
+
+readarray -t memdevs < <("$CXL" list -b cxl_test -Mi | jq -r '.[].host')
+
+echo "TEST: Prep event trace"
+echo "" > /sys/kernel/tracing/trace
+echo 1 > /sys/kernel/tracing/events/cxl/enable
+echo 1 > /sys/kernel/tracing/tracing_on
+
+# Only need to test 1 device
+#for memdev in ${memdevs[@]}; do
+#done
+
+test_cxl_events "$memdevs"
+
+echo 0 > /sys/kernel/tracing/tracing_on
+
+echo "TEST: Events seen"
+cat /sys/kernel/tracing/trace
+num_overflow=$(grep "cxl_overflow" /sys/kernel/tracing/trace | wc -l)
+num_fatal=$(grep "log=Fatal" /sys/kernel/tracing/trace | wc -l)
+num_failure=$(grep "log=Failure" /sys/kernel/tracing/trace | wc -l)
+num_info=$(grep "log=Informational" /sys/kernel/tracing/trace | wc -l)
+echo " LOG (Expected) : (Found)"
+echo " overflow ( 1) : $num_overflow"
+echo " Fatal ( 2) : $num_fatal"
+echo " Failure (16) : $num_failure"
+echo " Informational ( 3) : $num_info"
+
+if [ "$num_overflow" -ne 1 ]; then
+ err "$LINENO"
+fi
+if [ "$num_fatal" -ne 2 ]; then
+ err "$LINENO"
+fi
+if [ "$num_failure" -ne 16 ]; then
+ err "$LINENO"
+fi
+if [ "$num_info" -ne 3 ]; then
+ err "$LINENO"
+fi
+
+check_dmesg "$LINENO"
+
+modprobe -r cxl_test
diff --git a/test/meson.build b/test/meson.build
index a956885f6df6..a33255bde1a8 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -155,6 +155,7 @@ cxl_sysfs = find_program('cxl-region-sysfs.sh')
cxl_labels = find_program('cxl-labels.sh')
cxl_create_region = find_program('cxl-create-region.sh')
cxl_xor_region = find_program('cxl-xor-region.sh')
+cxl_events = find_program('cxl-events.sh')
tests = [
[ 'libndctl', libndctl, 'ndctl' ],
@@ -183,6 +184,7 @@ tests = [
[ 'cxl-labels.sh', cxl_labels, 'cxl' ],
[ 'cxl-create-region.sh', cxl_create_region, 'cxl' ],
[ 'cxl-xor-region.sh', cxl_xor_region, 'cxl' ],
+ [ 'cxl-events.sh', cxl_events, 'cxl' ],
]
if get_option('destructive').enabled()
---
base-commit: 2fd570a0ed788b1bd0971dfdb1466a5dbcb79775
change-id: 20230726-cxl-event-dc00a2f94b60
Best regards,
--
Ira Weiny <ira.weiny@intel.com>
next reply other threads:[~2023-07-27 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 21:21 Ira Weiny [this message]
2023-07-27 21:49 ` [PATCH ndctl] ndctl/cxl/test: Add CXL event test Dave Jiang
2023-07-28 0:15 ` Ira Weiny
2023-07-28 0:35 ` Dave Jiang
2023-07-31 19:54 ` Verma, Vishal L
2023-07-31 22:16 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726-cxl-event-v1-1-1cf8cb02b211@intel.com \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox