Linux CXL
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>
Cc: "Schofield, Alison" <alison.schofield@intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	<linux-cxl@vger.kernel.org>, <nvdimm@lists.linux.dev>
Subject: Re: [PATCH ndctl] ndctl/cxl/test: Add CXL event test
Date: Thu, 27 Jul 2023 17:15:56 -0700	[thread overview]
Message-ID: <64c308bc9a6e9_368368294fb@iweiny-mobl.notmuch> (raw)
In-Reply-To: <867b567f-45cc-d6f1-d5f4-cc68a80406b3@intel.com>

Dave Jiang wrote:
> 
> 
> On 7/27/23 14:21, Ira Weiny wrote:
> > Previously CXL event testing was run by hand.  This reduces testing
> > coverage including a lack of regression testing.
> > 
> > Add a CXL test as part of the meson test infrastructure.  Passing is
> > predicated on receiving the appropriate number of errors in each log.
> > Individual event values are not checked.
> > 
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> LGTM. Have you tried running shellcheck?

Never heard of it...  searching...

This?

	ShellCheck.x86_64 : Shell script analysis tool

> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>

Thanks,
Ira

  reply	other threads:[~2023-07-28  0:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27 21:21 [PATCH ndctl] ndctl/cxl/test: Add CXL event test Ira Weiny
2023-07-27 21:49 ` Dave Jiang
2023-07-28  0:15   ` Ira Weiny [this message]
2023-07-28  0:35     ` Dave Jiang
2023-07-31 19:54 ` Verma, Vishal L
2023-07-31 22:16   ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64c308bc9a6e9_368368294fb@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox