From: Jeongtae Park <jtp.park@samsung.com>
To: Dan Williams <dan.j.williams@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>, Fan Ni <fan.ni@samsung.com>,
linux-cxl@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kyungsan Kim <ks0204.kim@samsung.com>,
Wonjae Lee <wj28.lee@samsung.com>,
Hojin Nam <hj96.nam@samsung.com>,
Junhyeok Im <junhyeok.im@samsung.com>,
Jehoon Park <jehoon.park@samsung.com>,
Jeongtae Park <jeongtae.park@gmail.com>,
Jeongtae Park <jtp.park@samsung.com>
Subject: [PATCH 2/7] cxl/region: Fix a checkpatch warning
Date: Thu, 21 Sep 2023 11:51:05 +0900 [thread overview]
Message-ID: <20230921025110.3717583-3-jtp.park@samsung.com> (raw)
In-Reply-To: <20230921025110.3717583-1-jtp.park@samsung.com>
WARNING: else is not generally useful after a break or return
Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
---
drivers/cxl/core/region.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index e115ba382e04..1fc9d01c1ac0 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -133,11 +133,10 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
&cxlr->dev,
"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
return 0;
- } else {
- dev_err(&cxlr->dev,
- "Failed to synchronize CPU cache state\n");
- return -ENXIO;
}
+
+ dev_err(&cxlr->dev, "Failed to synchronize CPU cache state\n");
+ return -ENXIO;
}
cpu_cache_invalidate_memregion(IORES_DESC_CXL);
--
2.34.1
next prev parent reply other threads:[~2023-09-21 2:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230921024831epcas2p337d3d41f95bee75d2e2f3350bc48e70d@epcas2p3.samsung.com>
2023-09-21 2:51 ` [PATCH 0/7] cxl: Fix checkpatch issues Jeongtae Park
2023-09-21 2:51 ` [PATCH 1/7] cxl/trace: Fix improper SPDX comment style for header file Jeongtae Park
2023-09-21 22:54 ` Dave Jiang
2023-09-21 2:51 ` Jeongtae Park [this message]
2023-09-21 22:55 ` [PATCH 2/7] cxl/region: Fix a checkpatch warning Dave Jiang
2023-09-21 2:51 ` [PATCH 3/7] cxl/mem: Fix a checkpatch error Jeongtae Park
2023-09-21 22:55 ` Dave Jiang
2023-09-21 2:51 ` [PATCH 4/7] cxl: " Jeongtae Park
2023-09-21 22:56 ` Dave Jiang
2023-09-21 2:51 ` [PATCH 5/7] cxl: Fix block comment style Jeongtae Park
2023-09-21 22:56 ` Dave Jiang
2023-09-21 2:51 ` [PATCH 6/7] cxl/memdev: Fix whitespace error/warnings Jeongtae Park
2023-09-21 22:57 ` Dave Jiang
2023-09-22 9:23 ` Jeongtae Park
2023-09-21 2:51 ` [PATCH 7/7] cxl/trace: Enclose a multiple statements macro in a do while loop Jeongtae Park
2023-09-21 22:58 ` Dave Jiang
2023-09-22 9:26 ` Jeongtae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921025110.3717583-3-jtp.park@samsung.com \
--to=jtp.park@samsung.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hj96.nam@samsung.com \
--cc=jehoon.park@samsung.com \
--cc=jeongtae.park@gmail.com \
--cc=jonathan.cameron@huawei.com \
--cc=junhyeok.im@samsung.com \
--cc=ks0204.kim@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=wj28.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox