From: Jeongtae Park <jtp.park@samsung.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Davidlohr Bueso <dave@stgolabs.net>, Fan Ni <fan.ni@samsung.com>,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kyungsan Kim <ks0204.kim@samsung.com>,
Wonjae Lee <wj28.lee@samsung.com>,
Hojin Nam <hj96.nam@samsung.com>,
Junhyeok Im <junhyeok.im@samsung.com>,
Jehoon Park <jehoon.park@samsung.com>,
Jeongtae Park <jeongtae.park@gmail.com>
Subject: Re: [PATCH 6/7] cxl/memdev: Fix whitespace error/warnings
Date: Fri, 22 Sep 2023 18:23:46 +0900 [thread overview]
Message-ID: <ZQ1dIr//9aYNktzI@jtpark-7920> (raw)
In-Reply-To: <e14ac1d0-ef8e-74ab-0616-f3203580b371@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]
On Thu, Sep 21, 2023 at 03:57:25PM -0700, Dave Jiang wrote:
>
>
> On 9/20/23 19:51, Jeongtae Park wrote:
> > ERROR: code indent should use tabs where possible
> > WARNING: please, no spaces at the start of a line
> >
> > Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
>
> two different issues?
>
Yes, they are. I will seperate and resend them.
> > ---
> > drivers/cxl/core/memdev.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> > index f99e7ec3cc40..ce67df163452 100644
> > --- a/drivers/cxl/core/memdev.c
> > +++ b/drivers/cxl/core/memdev.c
> > @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl)
> > }
> >
> > static const struct fw_upload_ops cxl_memdev_fw_ops = {
> > - .prepare = cxl_fw_prepare,
> > - .write = cxl_fw_write,
> > - .poll_complete = cxl_fw_poll_complete,
> > - .cancel = cxl_fw_cancel,
> > - .cleanup = cxl_fw_cleanup,
> > + .prepare = cxl_fw_prepare,
> > + .write = cxl_fw_write,
> > + .poll_complete = cxl_fw_poll_complete,
> > + .cancel = cxl_fw_cancel,
> > + .cleanup = cxl_fw_cleanup,
> > };
> >
> > static void devm_cxl_remove_fw_upload(void *fwl)
> > @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd)
> > }
> >
> > return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds);
> > - }
> > +}
> >
> > struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds)
> > {
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2023-09-22 9:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230921024831epcas2p337d3d41f95bee75d2e2f3350bc48e70d@epcas2p3.samsung.com>
2023-09-21 2:51 ` [PATCH 0/7] cxl: Fix checkpatch issues Jeongtae Park
2023-09-21 2:51 ` [PATCH 1/7] cxl/trace: Fix improper SPDX comment style for header file Jeongtae Park
2023-09-21 22:54 ` Dave Jiang
2023-09-21 2:51 ` [PATCH 2/7] cxl/region: Fix a checkpatch warning Jeongtae Park
2023-09-21 22:55 ` Dave Jiang
2023-09-21 2:51 ` [PATCH 3/7] cxl/mem: Fix a checkpatch error Jeongtae Park
2023-09-21 22:55 ` Dave Jiang
2023-09-21 2:51 ` [PATCH 4/7] cxl: " Jeongtae Park
2023-09-21 22:56 ` Dave Jiang
2023-09-21 2:51 ` [PATCH 5/7] cxl: Fix block comment style Jeongtae Park
2023-09-21 22:56 ` Dave Jiang
2023-09-21 2:51 ` [PATCH 6/7] cxl/memdev: Fix whitespace error/warnings Jeongtae Park
2023-09-21 22:57 ` Dave Jiang
2023-09-22 9:23 ` Jeongtae Park [this message]
2023-09-21 2:51 ` [PATCH 7/7] cxl/trace: Enclose a multiple statements macro in a do while loop Jeongtae Park
2023-09-21 22:58 ` Dave Jiang
2023-09-22 9:26 ` Jeongtae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ1dIr//9aYNktzI@jtpark-7920 \
--to=jtp.park@samsung.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hj96.nam@samsung.com \
--cc=jehoon.park@samsung.com \
--cc=jeongtae.park@gmail.com \
--cc=jonathan.cameron@huawei.com \
--cc=junhyeok.im@samsung.com \
--cc=ks0204.kim@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=wj28.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox