From: Ira Weiny <ira.weiny@intel.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>,
Fan Ni <nifan.cxl@gmail.com>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
Ira Weiny <ira.weiny@intel.com>
Subject: [PATCH 1/2] cxl/cdat: Handle cdat table build errors
Date: Fri, 17 Nov 2023 17:14:21 -0800 [thread overview]
Message-ID: <20231117-fix-cdat-cs-v1-1-ffc2b116ca6c@intel.com> (raw)
In-Reply-To: <20231117-fix-cdat-cs-v1-0-ffc2b116ca6c@intel.com>
The callback for building CDAT tables may return negative error codes.
This was previously unhandled and will result in potentially huge
allocations later on in ct3_build_cdat()
Detect the negative error code and defer cdat building.
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
This likely needs to have some more robust error handling in the event
of errors. But this at least prevents more errors down the line with
invalid allocations.
---
hw/cxl/cxl-cdat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/cxl/cxl-cdat.c b/hw/cxl/cxl-cdat.c
index 639a2db3e17b..24829cf2428d 100644
--- a/hw/cxl/cxl-cdat.c
+++ b/hw/cxl/cxl-cdat.c
@@ -63,7 +63,7 @@ static void ct3_build_cdat(CDATObject *cdat, Error **errp)
cdat->built_buf_len = cdat->build_cdat_table(&cdat->built_buf,
cdat->private);
- if (!cdat->built_buf_len) {
+ if (cdat->built_buf_len <= 0) {
/* Build later as not all data available yet */
cdat->to_update = true;
return;
--
2.41.0
next prev parent reply other threads:[~2023-11-18 1:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 1:14 [PATCH 0/2] cxl/cdat: Fixes for CXL CDAT processing Ira Weiny
2023-11-18 1:14 ` Ira Weiny [this message]
2023-11-20 15:40 ` [PATCH 1/2] cxl/cdat: Handle cdat table build errors Dave Jiang
2023-11-18 1:14 ` [PATCH 2/2] cxl/cdat: Fix header sum value in CDAT checksum Ira Weiny
2023-11-20 15:43 ` Dave Jiang
2023-11-27 20:48 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117-fix-cdat-cs-v1-1-ffc2b116ca6c@intel.com \
--to=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nifan.cxl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox