Re: [PATCH v2 04/16] cxl/test: Add Get Supported Features mailbox command support

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Fri, 31 Jan 2025 17:41:57 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> Add cxl-test emulation of Get Supported Features mailbox command.
> Currently only adding a test feature with feature identifier of
> all f's for testing.
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>


> +static int mock_get_supported_features(struct cxl_mockmem_data *mdata,
> +				       struct cxl_mbox_cmd *cmd)
> +{
> +	struct cxl_mbox_get_sup_feats_in *in = cmd->payload_in;
> +	struct cxl_mbox_get_sup_feats_out *out = cmd->payload_out;
> +	struct cxl_feat_entry *feat;
> +	u16 start_idx, count;
> +
> +	if (cmd->size_out < sizeof(*out)) {
> +		cmd->return_code = CXL_MBOX_CMD_RC_PAYLOADLEN;
> +		return -EINVAL;
> +	}
> +
> +	/*
> +	 * Current emulation only supports 1 feature
> +	 */
> +	start_idx = le16_to_cpu(in->start_idx);
> +	if (start_idx != 0) {
> +		cmd->return_code = CXL_MBOX_CMD_RC_INPUT;
> +		return -EINVAL;
> +	}
> +
> +	count = le16_to_cpu(in->count);
> +	if (count < sizeof(*out)) {
> +		cmd->return_code = CXL_MBOX_CMD_RC_PAYLOADLEN;
> +		return -EINVAL;
> +	}
> +
> +	out->supported_feats = cpu_to_le16(1);
> +	cmd->return_code = 0;
> +	if (count < sizeof(*out) + sizeof(*feat)) {

struct_size() probably makes sense here as well.

> +		out->num_entries = 0;
> +		return 0;
> +	}
> +
> +	out->num_entries = cpu_to_le16(1);
> +	feat = out->ents;
> +	fill_feature_vendor_test(feat);
> +
> +	return 0;
> +}
> +
>  static int cxl_mock_mbox_send(struct cxl_mailbox *cxl_mbox,
>  			      struct cxl_mbox_cmd *cmd)
>  {
> @@ -1422,6 +1487,9 @@ static int cxl_mock_mbox_send(struct cxl_mailbox *cxl_mbox,
>  	case CXL_MBOX_OP_ACTIVATE_FW:
>  		rc = mock_activate_fw(mdata, cmd);
>  		break;
> +	case CXL_MBOX_OP_GET_SUPPORTED_FEATURES:
> +		rc = mock_get_supported_features(mdata, cmd);
> +		break;
>  	default:
>  		break;
>  	}