From: Jason Gunthorpe <jgg@nvidia.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
linux-cxl@vger.kernel.org, dan.j.williams@intel.com,
ira.weiny@intel.com, vishal.l.verma@intel.com,
alison.schofield@intel.com, dave@stgolabs.net,
shiju.jose@huawei.com
Subject: Re: [PATCH v2 08/16] cxl: Add FWCTL support to the CXL memdev driver
Date: Mon, 3 Feb 2025 10:25:54 -0400 [thread overview]
Message-ID: <20250203142554.GV5556@nvidia.com> (raw)
In-Reply-To: <20250203124232.00003dd2@huawei.com>
On Mon, Feb 03, 2025 at 12:42:32PM +0000, Jonathan Cameron wrote:
> > diff --git a/drivers/cxl/features.c b/drivers/cxl/features.c
> > index 82598a409acc..2dcfefdfa6b3 100644
> > --- a/drivers/cxl/features.c
> > +++ b/drivers/cxl/features.c
>
> >
> > +/* The __weak symbol gets replaced by FWCTL allocation function in fwctl.c */
> > +struct cxl_features_state * __weak devm_cxlfs_allocate(struct cxl_memdev *cxlmd)
> > +{
> This use of weak functions is a bit too clever for me to be entirely happy but it
> seems right so fair enough.
weak functions have become frowned upon lately and I can't clearly see
why you'd want this? Can you do it without it please?
Jason
next prev parent reply other threads:[~2025-02-03 14:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 0:41 [PATCH v2 0/16] cxl: Add CXL feature commands support via fwctl Dave Jiang
2025-02-01 0:41 ` [PATCH v2 01/16] cxl: Refactor user ioctl command path from mds to mailbox Dave Jiang
2025-02-01 0:41 ` [PATCH v2 02/16] cxl: Enumerate feature commands Dave Jiang
2025-02-03 12:06 ` Jonathan Cameron
2025-02-03 23:23 ` Dave Jiang
2025-02-01 0:41 ` [PATCH v2 03/16] cxl: Add Get Supported Features command for kernel usage Dave Jiang
2025-02-03 12:19 ` Jonathan Cameron
2025-02-01 0:41 ` [PATCH v2 04/16] cxl/test: Add Get Supported Features mailbox command support Dave Jiang
2025-02-03 12:22 ` Jonathan Cameron
2025-02-01 0:41 ` [PATCH v2 05/16] cxl/mbox: Add GET_FEATURE mailbox command Dave Jiang
2025-02-01 0:41 ` [PATCH v2 06/16] cxl/mbox: Add SET_FEATURE " Dave Jiang
2025-02-03 12:27 ` Jonathan Cameron
2025-02-01 0:42 ` [PATCH v2 07/16] cxl: Setup exclusive CXL features that are reserved for the kernel Dave Jiang
2025-02-01 0:42 ` [PATCH v2 08/16] cxl: Add FWCTL support to the CXL memdev driver Dave Jiang
2025-02-01 1:04 ` Dave Jiang
2025-02-03 12:42 ` Jonathan Cameron
2025-02-03 14:25 ` Jason Gunthorpe [this message]
2025-02-03 16:22 ` Dave Jiang
2025-02-03 16:30 ` Jason Gunthorpe
2025-02-01 0:42 ` [PATCH v2 09/16] cxl: Add support for FWCTL get driver information callback Dave Jiang
2025-02-03 12:43 ` Jonathan Cameron
2025-02-01 0:42 ` [PATCH v2 10/16] cxl: Move cxl feature command structs to user header Dave Jiang
2025-02-01 0:42 ` [PATCH v2 11/16] cxl: Add support for fwctl RPC command to enable CXL feature commands Dave Jiang
2025-02-03 13:03 ` Jonathan Cameron
2025-02-01 0:42 ` [PATCH v2 12/16] cxl: Add support to handle user feature commands for get feature Dave Jiang
2025-02-01 0:42 ` [PATCH v2 13/16] cxl: Add support to handle user feature commands for set feature Dave Jiang
2025-02-01 0:42 ` [PATCH v2 14/16] cxl/test: Add Get Feature support to cxl_test Dave Jiang
2025-02-01 0:42 ` [PATCH v2 15/16] cxl/test: Add Set " Dave Jiang
2025-02-01 0:42 ` [PATCH v2 16/16] fwctl/cxl: Add documentation to FWCTL CXL Dave Jiang
2025-02-03 13:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203142554.GV5556@nvidia.com \
--to=jgg@nvidia.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox