From: Dave Jiang <dave.jiang@intel.com>
To: linux-cxl@vger.kernel.org
Cc: dan.j.williams@intel.com, ira.weiny@intel.com,
vishal.l.verma@intel.com, alison.schofield@intel.com,
Jonathan.Cameron@huawei.com, dave@stgolabs.net, jgg@nvidia.com,
shiju.jose@huawei.com
Subject: [PATCH v3 14/16] cxl/test: Add Get Feature support to cxl_test
Date: Tue, 4 Feb 2025 15:03:15 -0700 [thread overview]
Message-ID: <20250204220430.4146187-15-dave.jiang@intel.com> (raw)
In-Reply-To: <20250204220430.4146187-1-dave.jiang@intel.com>
Add emulation of Get Feature command to cxl_test. The feature for
device patrol scrub is returned by the emulation code. This is
the only feature currently supported by cxl_test. It returns
the information for the device patrol scrub feature.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
tools/testing/cxl/test/mem.c | 57 ++++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
index 90069dd686b5..aab5905b56c3 100644
--- a/tools/testing/cxl/test/mem.c
+++ b/tools/testing/cxl/test/mem.c
@@ -48,6 +48,10 @@ static struct cxl_cel_entry mock_cel[] = {
.opcode = cpu_to_le16(CXL_MBOX_OP_GET_SUPPORTED_FEATURES),
.effect = CXL_CMD_EFFECT_NONE,
},
+ {
+ .opcode = cpu_to_le16(CXL_MBOX_OP_GET_FEATURE),
+ .effect = CXL_CMD_EFFECT_NONE,
+ },
{
.opcode = cpu_to_le16(CXL_MBOX_OP_IDENTIFY),
.effect = CXL_CMD_EFFECT_NONE,
@@ -149,6 +153,10 @@ struct mock_event_store {
u32 ev_status;
};
+struct vendor_test_feat {
+ __le32 data;
+} __packed;
+
struct cxl_mockmem_data {
void *lsa;
void *fw;
@@ -165,6 +173,7 @@ struct cxl_mockmem_data {
u8 event_buf[SZ_4K];
u64 timestamp;
unsigned long sanitize_timeout;
+ struct vendor_test_feat test_feat;
};
static struct mock_event_log *event_find_log(struct device *dev, int log_type)
@@ -1360,8 +1369,47 @@ static void fill_feature_vendor_test(struct cxl_feat_entry *feat)
CXL_CMD_EFFECTS_VALID);
}
+
#define MAX_CXL_TEST_FEATS 1
+static int mock_get_test_feature(struct cxl_mockmem_data *mdata,
+ struct cxl_mbox_cmd *cmd)
+{
+ struct vendor_test_feat *output = cmd->payload_out;
+ struct cxl_mbox_get_feat_in *input = cmd->payload_in;
+ u16 offset = le16_to_cpu(input->offset);
+ u16 count = le16_to_cpu(input->count);
+ u8 *ptr;
+
+ if (offset > sizeof(*output)) {
+ cmd->return_code = CXL_MBOX_CMD_RC_INPUT;
+ return -EINVAL;
+ }
+
+ if (offset + count > sizeof(*output)) {
+ cmd->return_code = CXL_MBOX_CMD_RC_INPUT;
+ return -EINVAL;
+ }
+
+ ptr = (u8 *)&mdata->test_feat + offset;
+ memcpy((u8 *)output + offset, ptr, count);
+
+ return 0;
+}
+
+static int mock_get_feature(struct cxl_mockmem_data *mdata,
+ struct cxl_mbox_cmd *cmd)
+{
+ struct cxl_mbox_get_feat_in *input = cmd->payload_in;
+
+ if (uuid_equal(&input->uuid, &CXL_VENDOR_FEATURE_TEST))
+ return mock_get_test_feature(mdata, cmd);
+
+ cmd->return_code = CXL_MBOX_CMD_RC_UNSUPPORTED;
+
+ return -EOPNOTSUPP;
+}
+
static int mock_get_supported_features(struct cxl_mockmem_data *mdata,
struct cxl_mbox_cmd *cmd)
{
@@ -1492,6 +1540,9 @@ static int cxl_mock_mbox_send(struct cxl_mailbox *cxl_mbox,
case CXL_MBOX_OP_GET_SUPPORTED_FEATURES:
rc = mock_get_supported_features(mdata, cmd);
break;
+ case CXL_MBOX_OP_GET_FEATURE:
+ rc = mock_get_feature(mdata, cmd);
+ break;
default:
break;
}
@@ -1539,6 +1590,11 @@ static int cxl_mock_mailbox_create(struct cxl_dev_state *cxlds)
return 0;
}
+static void cxl_mock_test_feat_init(struct cxl_mockmem_data *mdata)
+{
+ mdata->test_feat.data = cpu_to_le32(0xdeadbeef);
+}
+
static int cxl_mock_mem_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -1626,6 +1682,7 @@ static int cxl_mock_mem_probe(struct platform_device *pdev)
return rc;
cxl_mem_get_event_records(mds, CXLDEV_EVENT_STATUS_ALL);
+ cxl_mock_test_feat_init(mdata);
return 0;
}
--
2.48.1
next prev parent reply other threads:[~2025-02-04 22:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 22:03 [PATCH v3 00/16] cxl: Add CXL feature commands support via fwctl Dave Jiang
2025-02-04 22:03 ` [PATCH v3 01/16] cxl: Refactor user ioctl command path from mds to mailbox Dave Jiang
2025-02-05 17:41 ` Jonathan Cameron
2025-02-05 17:52 ` Dave Jiang
2025-02-07 5:47 ` Li Ming
2025-02-04 22:03 ` [PATCH v3 02/16] cxl: Enumerate feature commands Dave Jiang
2025-02-04 23:34 ` Dan Williams
2025-02-04 22:03 ` [PATCH v3 03/16] cxl: Add Get Supported Features command for kernel usage Dave Jiang
2025-02-04 23:50 ` Dan Williams
2025-02-07 5:42 ` Li Ming
2025-02-08 0:03 ` Dave Jiang
2025-02-04 22:03 ` [PATCH v3 04/16] cxl/test: Add Get Supported Features mailbox command support Dave Jiang
2025-02-07 5:51 ` Li Ming
2025-02-04 22:03 ` [PATCH v3 05/16] cxl/mbox: Add GET_FEATURE mailbox command Dave Jiang
2025-02-05 0:54 ` Dan Williams
2025-02-05 17:57 ` Jonathan Cameron
2025-02-05 23:12 ` Dan Williams
2025-02-06 11:03 ` Jonathan Cameron
2025-02-07 20:18 ` Dan Williams
2025-02-07 6:18 ` Li Ming
2025-02-04 22:03 ` [PATCH v3 06/16] cxl/mbox: Add SET_FEATURE " Dave Jiang
2025-02-04 22:03 ` [PATCH v3 07/16] cxl: Setup exclusive CXL features that are reserved for the kernel Dave Jiang
2025-02-04 22:03 ` [PATCH v3 08/16] cxl: Add FWCTL support to the CXL memdev driver Dave Jiang
2025-02-05 1:18 ` Dan Williams
2025-02-04 22:03 ` [PATCH v3 09/16] cxl: Add support for FWCTL get driver information callback Dave Jiang
2025-02-05 1:27 ` Dan Williams
2025-02-04 22:03 ` [PATCH v3 10/16] cxl: Move cxl feature command structs to user header Dave Jiang
2025-02-04 22:03 ` [PATCH v3 11/16] cxl: Add support for fwctl RPC command to enable CXL feature commands Dave Jiang
2025-02-05 1:41 ` Dan Williams
2025-02-04 22:03 ` [PATCH v3 12/16] cxl: Add support to handle user feature commands for get feature Dave Jiang
2025-02-04 22:03 ` [PATCH v3 13/16] cxl: Add support to handle user feature commands for set feature Dave Jiang
2025-02-04 22:03 ` Dave Jiang [this message]
2025-02-04 22:03 ` [PATCH v3 15/16] cxl/test: Add Set Feature support to cxl_test Dave Jiang
2025-02-04 22:03 ` [PATCH v3 16/16] fwctl/cxl: Add documentation to FWCTL CXL Dave Jiang
2025-02-05 1:50 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204220430.4146187-15-dave.jiang@intel.com \
--to=dave.jiang@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jgg@nvidia.com \
--cc=linux-cxl@vger.kernel.org \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox