Re: [PATCH] cxl: Add comment about 'cxl_root_decoder' and flex array

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Wed, 11 Jun 2025 19:19:47 +0800
Li Ming <ming.li@zohomail.com> wrote:

> On 6/11/2025 1:54 AM, Dave Jiang wrote:
> > Add a warning comment for 'struct cxl_root_decoder' to not add members
> > after 'cxlsd' since 'cxlsd' has flex array at the end.
> >
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>  
> Reviewed-by: Li Ming <ming.li@zohomail.com>

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

Mind you this is pretty common and I thought we now had instrumentation
to catch if anyone broke this rule?  Maybe that project isn't quite
there yet.

> > ---
> >  drivers/cxl/cxl.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> > index 9a17e8beca7a..68596e9216f3 100644
> > --- a/drivers/cxl/cxl.h
> > +++ b/drivers/cxl/cxl.h
> > @@ -445,6 +445,7 @@ struct cxl_root_decoder {
> >  	int qos_class;
> >  	const struct cxl_rd_ops *ops;
> >  	struct cxl_switch_decoder cxlsd;
> > +	/* DO NOT ADD AFTER THIS POINT, cxlsd has flex array component */
> >  };
> >  
> >  /*
> >
> > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > prerequisite-patch-id: 77982cd1ed494cf0f747ccf74c6b8949be9837d6  
> 
>