From: Dave Jiang <dave.jiang@intel.com>
To: linux-cxl@vger.kernel.org
Cc: dave@stgolabs.net, jonathan.cameron@huawei.com,
alison.schofield@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, dan.j.williams@intel.com
Subject: Re: [PATCH] cxl: Add comment about 'cxl_root_decoder' and flex array
Date: Wed, 11 Jun 2025 08:40:39 -0700 [thread overview]
Message-ID: <ba4ed993-539e-4ad4-b85b-afd0416166b1@intel.com> (raw)
In-Reply-To: <20250610175401.172660-1-dave.jiang@intel.com>
On 6/10/25 10:54 AM, Dave Jiang wrote:
> Add a warning comment for 'struct cxl_root_decoder' to not add members
> after 'cxlsd' since 'cxlsd' has flex array at the end.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Applied to cxl/next
> ---
> drivers/cxl/cxl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 9a17e8beca7a..68596e9216f3 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -445,6 +445,7 @@ struct cxl_root_decoder {
> int qos_class;
> const struct cxl_rd_ops *ops;
> struct cxl_switch_decoder cxlsd;
> + /* DO NOT ADD AFTER THIS POINT, cxlsd has flex array component */
> };
>
> /*
>
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> prerequisite-patch-id: 77982cd1ed494cf0f747ccf74c6b8949be9837d6
prev parent reply other threads:[~2025-06-11 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 17:54 [PATCH] cxl: Add comment about 'cxl_root_decoder' and flex array Dave Jiang
2025-06-11 11:19 ` Li Ming
2025-06-11 13:28 ` Jonathan Cameron
2025-06-11 15:40 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba4ed993-539e-4ad4-b85b-afd0416166b1@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox