From: Dan Williams <dan.j.williams@intel.com>
To: <alison.schofield@intel.com>
Cc: <nvdimm@lists.linux.dev>, <linux-cxl@vger.kernel.org>
Subject: [ndctl PATCH 1/5] build: Fix meson feature deprecation warnings
Date: Wed, 18 Jun 2025 15:21:26 -0700 [thread overview]
Message-ID: <20250618222130.672621-2-dan.j.williams@intel.com> (raw)
In-Reply-To: <20250618222130.672621-1-dan.j.williams@intel.com>
There are a few instances of the warning:
"meson.build: WARNING: Project does not target a minimum version but
uses feature deprecated since '0.56.0': dependency.get_pkgconfig_variable.
use dependency.get_variable(pkgconfig : ...) instead"
Move to the new style and mark the project as needing at least that minimum
version.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
contrib/meson.build | 2 +-
meson.build | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/contrib/meson.build b/contrib/meson.build
index 48aa7c071f92..33a409a2d7d0 100644
--- a/contrib/meson.build
+++ b/contrib/meson.build
@@ -2,7 +2,7 @@ bashcompletiondir = get_option('bashcompletiondir')
if bashcompletiondir == ''
bash_completion = dependency('bash-completion', required : false)
if bash_completion.found()
- bashcompletiondir = bash_completion.get_pkgconfig_variable('completionsdir')
+ bashcompletiondir = bash_completion.get_variable(pkgconfig : 'completionsdir')
else
bashcompletiondir = datadir / 'bash-completion/completions'
endif
diff --git a/meson.build b/meson.build
index 19808bb21db8..300eddb99235 100644
--- a/meson.build
+++ b/meson.build
@@ -1,5 +1,6 @@
project('ndctl', 'c',
version : '82',
+ meson_version: '>= 0.56.0',
license : [
'GPL-2.0',
'LGPL-2.1',
@@ -159,9 +160,9 @@ endif
if get_option('systemd').enabled()
systemd = dependency('systemd', required : true)
- systemdunitdir = systemd.get_pkgconfig_variable('systemdsystemunitdir')
+ systemdunitdir = systemd.get_variable(pkgconfig : 'systemdsystemunitdir')
udev = dependency('udev', required : true)
- udevdir = udev.get_pkgconfig_variable('udevdir')
+ udevdir = udev.get_variable(pkgconfig : 'udevdir')
udevrulesdir = udevdir / 'rules.d'
endif
--
2.49.0
next prev parent reply other threads:[~2025-06-18 22:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 22:21 [ndctl PATCH 0/5] ndctl: Add missing test dependencies and other fixups Dan Williams
2025-06-18 22:21 ` Dan Williams [this message]
2025-06-18 22:25 ` [ndctl PATCH 1/5] build: Fix meson feature deprecation warnings Dave Jiang
2025-06-18 22:21 ` [ndctl PATCH 2/5] test: Fix 'ndctl' dependency in test/sub-section.sh Dan Williams
2025-06-18 22:26 ` Dave Jiang
2025-06-18 22:21 ` [ndctl PATCH 3/5] test: Fix dax.sh expectations Dan Williams
2025-06-18 22:28 ` Dave Jiang
2025-06-19 1:06 ` Alison Schofield
2025-06-19 1:09 ` Dan Williams
2025-06-20 20:11 ` Verma, Vishal L
2025-06-20 20:19 ` Alison Schofield
2025-06-18 22:21 ` [ndctl PATCH 4/5] test: Update documentation with required packages to install Dan Williams
2025-06-18 22:31 ` Dave Jiang
2025-06-18 22:21 ` [ndctl PATCH 5/5] test: Fixup fwctl dependency Dan Williams
2025-06-18 22:32 ` Dave Jiang
2025-06-19 1:18 ` [ndctl PATCH 0/5] ndctl: Add missing test dependencies and other fixups Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618222130.672621-2-dan.j.williams@intel.com \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox