From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, alison.schofield@intel.com
Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: Re: [ndctl PATCH 2/5] test: Fix 'ndctl' dependency in test/sub-section.sh
Date: Wed, 18 Jun 2025 15:26:06 -0700 [thread overview]
Message-ID: <80b30472-dc74-498f-9469-41f5a829de94@intel.com> (raw)
In-Reply-To: <20250618222130.672621-3-dan.j.williams@intel.com>
On 6/18/25 3:21 PM, Dan Williams wrote:
> The test fails with:
>
> "sub-section.sh: line 23: ndctl: command not found"
>
> ...it should be using the built ndctl program, not the one installed in the
> filesystem.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> test/sub-section.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/sub-section.sh b/test/sub-section.sh
> index 77b963355c8f..5acc25eefe87 100755
> --- a/test/sub-section.sh
> +++ b/test/sub-section.sh
> @@ -20,7 +20,7 @@ MIN_AVAIL=$((TEST_SIZE*4))
> MAX_NS=10
> NAME="subsection-test"
>
> -ndctl list -N | jq -r ".[] | select(.name==\"subsection-test\") | .dev"
> +$NDCTL list -N | jq -r ".[] | select(.name==\"subsection-test\") | .dev"
>
> rc=$FAIL
> cleanup() {
next prev parent reply other threads:[~2025-06-18 22:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 22:21 [ndctl PATCH 0/5] ndctl: Add missing test dependencies and other fixups Dan Williams
2025-06-18 22:21 ` [ndctl PATCH 1/5] build: Fix meson feature deprecation warnings Dan Williams
2025-06-18 22:25 ` Dave Jiang
2025-06-18 22:21 ` [ndctl PATCH 2/5] test: Fix 'ndctl' dependency in test/sub-section.sh Dan Williams
2025-06-18 22:26 ` Dave Jiang [this message]
2025-06-18 22:21 ` [ndctl PATCH 3/5] test: Fix dax.sh expectations Dan Williams
2025-06-18 22:28 ` Dave Jiang
2025-06-19 1:06 ` Alison Schofield
2025-06-19 1:09 ` Dan Williams
2025-06-20 20:11 ` Verma, Vishal L
2025-06-20 20:19 ` Alison Schofield
2025-06-18 22:21 ` [ndctl PATCH 4/5] test: Update documentation with required packages to install Dan Williams
2025-06-18 22:31 ` Dave Jiang
2025-06-18 22:21 ` [ndctl PATCH 5/5] test: Fixup fwctl dependency Dan Williams
2025-06-18 22:32 ` Dave Jiang
2025-06-19 1:18 ` [ndctl PATCH 0/5] ndctl: Add missing test dependencies and other fixups Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b30472-dc74-498f-9469-41f5a829de94@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox