From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: wangyuquan <wangyuquan1236@phytium.com.cn>
Cc: <fan.ni@samsung.com>, <mst@redhat.com>,
<marcel.apfelbaum@gmail.com>, <rad@semihalf.com>,
<peter.maydell@linaro.org>, <leif.lindholm@oss.qualcomm.com>,
<graf@amazon.com>, <claudio.fontana@huawei.com>,
<philmd@linaro.org>, <richard.henderson@linaro.org>,
<chenbaozi@phytium.com.cn>, <qemu-devel@nongnu.org>,
<linux-cxl@vger.kernel.org>
Subject: Re: [RFC QEMU PATCH v4 1/2] hw/pxb-cxl: Rename the pxb cxl host bridge
Date: Wed, 17 Sep 2025 17:32:42 +0100 [thread overview]
Message-ID: <20250917173242.00004009@huawei.com> (raw)
In-Reply-To: <20250807105910.240070-2-wangyuquan1236@phytium.com.cn>
On Thu, 7 Aug 2025 18:59:09 +0800
wangyuquan <wangyuquan1236@phytium.com.cn> wrote:
> This renames some descriptions and definitions of pxb cxl host
> bridge, since the original names can be confusing.
>
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
This is fine with me - sorry for my lack of attention on this series.
I'm not set up to test SBSA and for me it's not a focus, but I don't
want to get in your way!
Acked-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> hw/pci-bridge/pci_expander_bridge.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c
> index 3a29dfefc2..bd637786d0 100644
> --- a/hw/pci-bridge/pci_expander_bridge.c
> +++ b/hw/pci-bridge/pci_expander_bridge.c
> @@ -201,7 +201,7 @@ static void pxb_cxl_realize(DeviceState *dev, Error **errp)
> }
>
> /*
> - * Host bridge realization has no means of knowning state associated
> + * PXB Host bridge realization has no means of knowning state associated
> * with a particular machine. As such, it is nececssary to delay
> * final setup of the host bridge register space until later in the
> * machine bring up.
> @@ -240,7 +240,7 @@ static void pxb_cxl_host_class_init(ObjectClass *class, const void *data)
> * This is a device to handle the MMIO for a CXL host bridge. It does nothing
> * else.
> */
> -static const TypeInfo cxl_host_info = {
> +static const TypeInfo pxb_cxl_host_info = {
> .name = TYPE_PXB_CXL_HOST,
> .parent = TYPE_PCI_HOST_BRIDGE,
> .instance_size = sizeof(CXLHost),
> @@ -522,7 +522,7 @@ static void pxb_cxl_dev_class_init(ObjectClass *klass, const void *data)
> * vendor, device, class, etc. ids are intentionally left out.
> */
>
> - dc->desc = "CXL Host Bridge";
> + dc->desc = "PXB CXL Host Bridge";
> device_class_set_props(dc, pxb_cxl_dev_properties);
> set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>
> @@ -549,7 +549,7 @@ static void pxb_register_types(void)
> type_register_static(&pxb_pcie_bus_info);
> type_register_static(&pxb_cxl_bus_info);
> type_register_static(&pxb_host_info);
> - type_register_static(&cxl_host_info);
> + type_register_static(&pxb_cxl_host_info);
> type_register_static(&pxb_dev_info);
> type_register_static(&pxb_pcie_dev_info);
> type_register_static(&pxb_cxl_dev_info);
next prev parent reply other threads:[~2025-09-17 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 10:59 [RFC QEMU PATCH v4 0/2] cxl: Support creation of a new CXL Host Bridge wangyuquan
2025-08-07 10:59 ` [RFC QEMU PATCH v4 1/2] hw/pxb-cxl: Rename the pxb cxl host bridge wangyuquan
2025-09-17 16:32 ` Jonathan Cameron [this message]
2025-08-07 10:59 ` [RFC QEMU PATCH v4 2/2] pci-host/cxl: Support creation of a new CXL Host Bridge wangyuquan
2025-09-17 16:37 ` Jonathan Cameron
2025-09-18 2:59 ` Yuquan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917173242.00004009@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=chenbaozi@phytium.com.cn \
--cc=claudio.fontana@huawei.com \
--cc=fan.ni@samsung.com \
--cc=graf@amazon.com \
--cc=leif.lindholm@oss.qualcomm.com \
--cc=linux-cxl@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rad@semihalf.com \
--cc=richard.henderson@linaro.org \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox