From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] cxl/acpi: Make the XOR calculations available for testing
Date: Thu, 18 Sep 2025 16:32:29 +0100 [thread overview]
Message-ID: <20250918163229.00000393@huawei.com> (raw)
In-Reply-To: <76808ea6eb83a33dad50abc9707a4cf972d822d3.1758150087.git.alison.schofield@intel.com>
On Wed, 17 Sep 2025 17:10:31 -0700
Alison Schofield <alison.schofield@intel.com> wrote:
> In preparation for adding a test module that can exercise the address
> translation functions performed by the CXL Driver, refactor the XOR
> implementation like this:
>
> - Extract the core calculation into a standalone helper function,
> - Export the new function for use by test module cxl_translate only,
> - Enhance the parameter validation since this new function will be
> called from a test module with no guarantee of valid parameters,
> - Move the define of struct cxl_cxims_data to cxl.h so the test module
> can build xormaps.
>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Seems fine to me
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2025-09-18 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 0:10 [PATCH v3 0/3] CXL: Add a loadable module for address translation Alison Schofield
2025-09-18 0:10 ` [PATCH v3 1/3] cxl/region: Refactor address translation funcs for testing Alison Schofield
2025-09-18 22:56 ` Dave Jiang
2025-09-18 0:10 ` [PATCH v3 2/3] cxl/acpi: Make the XOR calculations available " Alison Schofield
2025-09-18 15:32 ` Jonathan Cameron [this message]
2025-09-18 22:57 ` Dave Jiang
2025-09-18 0:10 ` [PATCH v3 3/3] cxl/test: Add cxl_translate module for address translation testing Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250918163229.00000393@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox