* [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING
@ 2026-06-10 4:21 Ethan Nelson-Moore
2026-06-10 4:36 ` Richard Cheng
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-10 4:21 UTC (permalink / raw)
To: linux-cxl
Cc: Ethan Nelson-Moore, Davidlohr Bueso, Jonathan Cameron, Dave Jiang,
Alison Schofield, Vishal Verma, Ira Weiny, Dan Williams
A comment in drivers/cxl/port.c refers to CONFIG_PROVE_CXL_LOCKING,
which was removed in commit 38a34e10768c ("cxl: Drop
cxl_device_lock()"). That commit switched CXL subsystem locking to
custom lock classes, which can be validated via the standard
CONFIG_PROVE_LOCKING option. Update the comment to reflect this.
Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/cxl/port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c
index ada51948d52f..99cf77b6b699 100644
--- a/drivers/cxl/port.c
+++ b/drivers/cxl/port.c
@@ -18,7 +18,7 @@
* firmware) are managed in this drivers context. Each driver instance
* is responsible for tearing down the driver context of immediate
* descendant ports. The locking for this is validated by
- * CONFIG_PROVE_CXL_LOCKING.
+ * CONFIG_PROVE_LOCKING.
*
* The primary service this driver provides is presenting APIs to other
* drivers to utilize the decoders, and indicating to userspace (via bind
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING
2026-06-10 4:21 [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING Ethan Nelson-Moore
@ 2026-06-10 4:36 ` Richard Cheng
2026-06-10 4:39 ` Dan Williams
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Richard Cheng @ 2026-06-10 4:36 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: linux-cxl, Davidlohr Bueso, Jonathan Cameron, Dave Jiang,
Alison Schofield, Vishal Verma, Ira Weiny, Dan Williams
On Tue, Jun 09, 2026 at 09:21:01PM +0800, Ethan Nelson-Moore wrote:
> A comment in drivers/cxl/port.c refers to CONFIG_PROVE_CXL_LOCKING,
> which was removed in commit 38a34e10768c ("cxl: Drop
> cxl_device_lock()"). That commit switched CXL subsystem locking to
> custom lock classes, which can be validated via the standard
> CONFIG_PROVE_LOCKING option. Update the comment to reflect this.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
Hi Ethan,
Thanks for this, LGTM.
Reviewed-by: Richard Cheng <icheng@nvidia.com>
Best regards,
Richard Cheng.
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> drivers/cxl/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c
> index ada51948d52f..99cf77b6b699 100644
> --- a/drivers/cxl/port.c
> +++ b/drivers/cxl/port.c
> @@ -18,7 +18,7 @@
> * firmware) are managed in this drivers context. Each driver instance
> * is responsible for tearing down the driver context of immediate
> * descendant ports. The locking for this is validated by
> - * CONFIG_PROVE_CXL_LOCKING.
> + * CONFIG_PROVE_LOCKING.
> *
> * The primary service this driver provides is presenting APIs to other
> * drivers to utilize the decoders, and indicating to userspace (via bind
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING
2026-06-10 4:21 [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING Ethan Nelson-Moore
2026-06-10 4:36 ` Richard Cheng
@ 2026-06-10 4:39 ` Dan Williams
2026-06-10 16:59 ` Dave Jiang
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2026-06-10 4:39 UTC (permalink / raw)
To: Ethan Nelson-Moore, linux-cxl
Cc: Davidlohr Bueso, Jonathan Cameron, Dave Jiang, Alison Schofield,
Vishal Verma, Ira Weiny
On Tue, Jun 9, 2026, at 9:21 PM, Ethan Nelson-Moore wrote:
> A comment in drivers/cxl/port.c refers to CONFIG_PROVE_CXL_LOCKING,
> which was removed in commit 38a34e10768c ("cxl: Drop
> cxl_device_lock()"). That commit switched CXL subsystem locking to
> custom lock classes, which can be validated via the standard
> CONFIG_PROVE_LOCKING option. Update the comment to reflect this.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
Looks good,
Reviewed-by: Dan Williams <djbw@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING
2026-06-10 4:21 [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING Ethan Nelson-Moore
2026-06-10 4:36 ` Richard Cheng
2026-06-10 4:39 ` Dan Williams
@ 2026-06-10 16:59 ` Dave Jiang
2026-06-10 17:13 ` Alison Schofield
2026-06-10 17:17 ` Dave Jiang
4 siblings, 0 replies; 6+ messages in thread
From: Dave Jiang @ 2026-06-10 16:59 UTC (permalink / raw)
To: Ethan Nelson-Moore, linux-cxl
Cc: Davidlohr Bueso, Jonathan Cameron, Alison Schofield, Vishal Verma,
Ira Weiny, Dan Williams
On 6/9/26 9:21 PM, Ethan Nelson-Moore wrote:
> A comment in drivers/cxl/port.c refers to CONFIG_PROVE_CXL_LOCKING,
> which was removed in commit 38a34e10768c ("cxl: Drop
> cxl_device_lock()"). That commit switched CXL subsystem locking to
> custom lock classes, which can be validated via the standard
> CONFIG_PROVE_LOCKING option. Update the comment to reflect this.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/cxl/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c
> index ada51948d52f..99cf77b6b699 100644
> --- a/drivers/cxl/port.c
> +++ b/drivers/cxl/port.c
> @@ -18,7 +18,7 @@
> * firmware) are managed in this drivers context. Each driver instance
> * is responsible for tearing down the driver context of immediate
> * descendant ports. The locking for this is validated by
> - * CONFIG_PROVE_CXL_LOCKING.
> + * CONFIG_PROVE_LOCKING.
> *
> * The primary service this driver provides is presenting APIs to other
> * drivers to utilize the decoders, and indicating to userspace (via bind
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING
2026-06-10 4:21 [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING Ethan Nelson-Moore
` (2 preceding siblings ...)
2026-06-10 16:59 ` Dave Jiang
@ 2026-06-10 17:13 ` Alison Schofield
2026-06-10 17:17 ` Dave Jiang
4 siblings, 0 replies; 6+ messages in thread
From: Alison Schofield @ 2026-06-10 17:13 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: linux-cxl, Davidlohr Bueso, Jonathan Cameron, Dave Jiang,
Vishal Verma, Ira Weiny, Dan Williams
On Tue, Jun 09, 2026 at 09:21:01PM -0700, Ethan Nelson-Moore wrote:
> A comment in drivers/cxl/port.c refers to CONFIG_PROVE_CXL_LOCKING,
> which was removed in commit 38a34e10768c ("cxl: Drop
> cxl_device_lock()"). That commit switched CXL subsystem locking to
> custom lock classes, which can be validated via the standard
> CONFIG_PROVE_LOCKING option. Update the comment to reflect this.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING
2026-06-10 4:21 [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING Ethan Nelson-Moore
` (3 preceding siblings ...)
2026-06-10 17:13 ` Alison Schofield
@ 2026-06-10 17:17 ` Dave Jiang
4 siblings, 0 replies; 6+ messages in thread
From: Dave Jiang @ 2026-06-10 17:17 UTC (permalink / raw)
To: Ethan Nelson-Moore, linux-cxl
Cc: Davidlohr Bueso, Jonathan Cameron, Alison Schofield, Vishal Verma,
Ira Weiny, Dan Williams
On 6/9/26 9:21 PM, Ethan Nelson-Moore wrote:
> A comment in drivers/cxl/port.c refers to CONFIG_PROVE_CXL_LOCKING,
> which was removed in commit 38a34e10768c ("cxl: Drop
> cxl_device_lock()"). That commit switched CXL subsystem locking to
> custom lock classes, which can be validated via the standard
> CONFIG_PROVE_LOCKING option. Update the comment to reflect this.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Applied to cxl/next
f9f82e97d9c5411c2cb3b8338a21be91148ff18b
> ---
> drivers/cxl/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c
> index ada51948d52f..99cf77b6b699 100644
> --- a/drivers/cxl/port.c
> +++ b/drivers/cxl/port.c
> @@ -18,7 +18,7 @@
> * firmware) are managed in this drivers context. Each driver instance
> * is responsible for tearing down the driver context of immediate
> * descendant ports. The locking for this is validated by
> - * CONFIG_PROVE_CXL_LOCKING.
> + * CONFIG_PROVE_LOCKING.
> *
> * The primary service this driver provides is presenting APIs to other
> * drivers to utilize the decoders, and indicating to userspace (via bind
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-06-10 17:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 4:21 [PATCH] cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING Ethan Nelson-Moore
2026-06-10 4:36 ` Richard Cheng
2026-06-10 4:39 ` Dan Williams
2026-06-10 16:59 ` Dave Jiang
2026-06-10 17:13 ` Alison Schofield
2026-06-10 17:17 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox