Re: [PATCH v28 1/5] sfc: add cxl support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Probe error path skips `efx_fini_io` cleanup when `efx_cxl_init` fails, leaking PCI I/O mappings and regions.
--

commit f3841c5aaa83257b810b3b73eb3877f94fb0a964
Author: Alejandro Lucero <alucerop@amd.com>

sfc: add cxl support

This commit adds CXL initialization based on the new CXL API for accel
drivers and makes it dependent on kernel CXL configuration.

> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 8f136a11d3968..da008462096d0 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
[ ... ]
> @@ -1190,6 +1193,17 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
>  	if (rc)
>  		goto fail2;
>  
> +	/* A successful cxl initialization implies a CXL region created to be
> +	 * used for PIO buffers. If there is no CXL support legacy PIO buffers
> +	 * defined at specific PCI BAR regions will be used. If there is CXL
> +	 * support and the cxl initialization fails, the driver probe fails.
> +	 */
> +	rc = efx_cxl_init(probe_data);
> +	if (rc) {
> +		pci_err(pci_dev, "CXL initialization failed with error %d\n", rc);
> +		goto fail2;

[Severity: High]
Does this leak PCI I/O mappings and regions if efx_cxl_init() fails?

If efx_cxl_init() fails, the code jumps directly to fail2:

	rc = efx_init_io(...)
	if (rc)
		goto fail2;

	rc = efx_cxl_init(probe_data);
	if (rc) {
		...
		goto fail2;
	...
 fail3:
	efx_fini_io(efx);
 fail2:
	efx_cxl_exit(probe_data);
	efx_fini_struct(efx);

Because efx_init_io() completes successfully just prior to this, shouldn't
this error path jump to fail3 so that the I/O resources and PCI device
enable state are properly cleaned up?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260618181806.118745-1-alejandro.lucero-palau@amd.com?part=1