Re: [PATCH v28 3/5] cxl/sfc: Initialize dpa without a mailbox

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Malformed kernel-doc comment with a literal '+' character due to a diff artifact.
--

commit e64a1b07e5313555ece5e23f49237b31b36182be
Author: Alejandro Lucero <alucerop@amd.com>

cxl/sfc: Initialize dpa without a mailbox

This commit allows a Type2 driver to initialize DPA by giving the size of its
volatile hardware partition, avoiding reliance on a mailbox identify command.
It moves related functions to memdev and adds the sfc driver as a client.

> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index 33a3d2e7b13af..500f077f935df 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c

[ ... ]

> @@ -594,6 +594,73 @@ bool is_cxl_memdev(const struct device *dev)

[ ... ]

> +/**
> + * cxl_set_capacity: initialize dpa by a driver without a mailbox.
> + *
> ++ * @cxlds: pointer to cxl_dev_state

[Severity: Low]
This isn't a bug, but it looks like a literal + character was accidentally
included in the kernel-doc block. Was this an artifact left over from a
rebase resolution?

> + * @capacity: device volatile memory size
> + */
> +int cxl_set_capacity(struct cxl_dev_state *cxlds, u64 capacity)
> +{
> +	struct cxl_dpa_info range_info = {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260618181806.118745-1-alejandro.lucero-palau@amd.com?part=3