Re: [PATCH v5 13/13] cxl/ras: Make cxl_cper_handle_prot_err() static

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] CXL protocol error handling for memdevs silently fails because `match_memdev_by_parent` incorrectly compares a `struct device *` to a `struct pci_dev *`.
--

commit 4ee43d8db9fe927d9aa6ae55ad362c92db62074c
Author: Dave Jiang <dave.jiang@intel.com>

cxl/ras: Make cxl_cper_handle_prot_err() static

This commit drops the export and declaration of cxl_cper_handle_prot_err()
and makes it static, since its only caller remains in the same file.

> diff --git a/drivers/cxl/core/ras.c b/drivers/cxl/core/ras.c
> index 99fb00949c2fa..eceb33bc534b3 100644
> --- a/drivers/cxl/core/ras.c
> +++ b/drivers/cxl/core/ras.c
> @@ -77,7 +77,7 @@ static int match_memdev_by_parent(struct device *dev, const void *uport)
>  	return 0;
>  }
>  
> -void cxl_cper_handle_prot_err(struct cxl_cper_prot_err_work_data *data)
> +static void cxl_cper_handle_prot_err(struct cxl_cper_prot_err_work_data *data)
>  {

[Severity: High]
This is a pre-existing issue, but does this function silently fail to handle 
memory device protocol errors due to a pointer mismatch?

In cxl_cper_handle_prot_err(), bus_find_device() is called with pdev 
(a struct pci_dev *) as the match data:

	struct device *mem_dev __free(put_device) = bus_find_device(
		&cxl_bus_type, NULL, pdev, match_memdev_by_parent);

However, match_memdev_by_parent() expects uport to match dev->parent, which 
is a struct device *:

static int match_memdev_by_parent(struct device *dev, const void *uport)
{
	if (is_cxl_memdev(dev) && dev->parent == uport)
		return 1;
	return 0;
}

Because the struct device is embedded inside struct pci_dev at a non-zero 
offset, dev->parent will never equal pdev. This causes bus_find_device() to 
always return NULL, which silently ignores the protocol error instead of 
tracing it. 

Should bus_find_device() be passed &pdev->dev instead of pdev?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827203726.3027541-1-dave.jiang@intel.com?part=13