Linux CXL
 help / color / mirror / Atom feed
From: Anisa Su <anisa.su887@gmail.com>
To: linux-cxl@vger.kernel.org
Cc: benjamin.cheatham@amd.com, icheng@nvidia.com, dave@stgolabs.net,
	dave.jiang@intel.com, alison.schofield@intel.com,
	jic23@kernel.org, Anisa Su <anisa.su@samsung.com>
Subject: [PATCH v2 4/4] cxl/events: Return IRQ_NONE when no events were processed
Date: Mon, 31 Aug 2026 17:26:57 -0700	[thread overview]
Message-ID: <20260901002912.958-5-anisa.su@samsung.com> (raw)
In-Reply-To: <20260901002912.958-1-anisa.su@samsung.com>

cxl_event_thread() returns IRQ_HANDLED whether or not it found
anything to do. Claiming every interrupt as handled means a device
flooding its MSI vector is never detected.

Return IRQ_NONE unless the Event Status register names a log to drain.

Fixes: a49aa8141b65 ("cxl/mem: Wire up event interrupts")
Signed-off-by: Anisa Su <anisa.su@samsung.com>
---
 drivers/cxl/pci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
index 239df18c9c87..94ff2b7d1f09 100644
--- a/drivers/cxl/pci.c
+++ b/drivers/cxl/pci.c
@@ -528,6 +528,7 @@ static irqreturn_t cxl_event_thread(int irq, void *id)
 	struct cxl_memdev_state *mds = to_cxl_memdev_state(cxlds);
 	u32 mask = CXLDEV_EVENT_STATUS_ALL;
 	int attempts = CXL_EVENT_DRAIN_ATTEMPTS;
+	bool handled = false;
 
 	while (mask) {
 		u32 status, drained, stuck;
@@ -542,6 +543,7 @@ static irqreturn_t cxl_event_thread(int irq, void *id)
 		status &= mask;
 		if (!status)
 			break;
+		handled = true;
 
 		rc = cxl_mem_get_event_records(mds, status, &drained);
 		if (rc) {
@@ -579,7 +581,7 @@ static irqreturn_t cxl_event_thread(int irq, void *id)
 		cond_resched();
 	}
 
-	return IRQ_HANDLED;
+	return handled ? IRQ_HANDLED : IRQ_NONE;
 }
 
 static int cxl_event_req_irq(struct cxl_dev_state *cxlds, u8 setting)
-- 
2.43.0


  parent reply	other threads:[~2026-09-01  0:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  0:26 [PATCH v2 0/4] cxl/events: Robustify event interrupt handling Anisa Su
2026-09-01  0:26 ` [PATCH v2 1/4] cxl/events: Bound get records loop in cxl_event_thread() Anisa Su
2026-09-01  0:41   ` sashiko-bot
2026-09-01 11:48   ` Li Ming
2026-09-01 17:59     ` Anisa Su
2026-09-01 19:17   ` Cheatham, Benjamin
2026-09-01  0:26 ` [PATCH v2 2/4] cxl/events: Validate the record count reported by the device Anisa Su
2026-09-01 19:19   ` Cheatham, Benjamin
2026-09-01  0:26 ` [PATCH v2 3/4] cxl/events: Bound the per-log Get Event Records loop Anisa Su
2026-09-01  0:43   ` sashiko-bot
2026-09-01 19:19   ` Cheatham, Benjamin
2026-09-01  0:26 ` Anisa Su [this message]
2026-09-01  0:38   ` [PATCH v2 4/4] cxl/events: Return IRQ_NONE when no events were processed sashiko-bot
2026-09-01 19:19   ` Cheatham, Benjamin
2026-09-02  8:27 ` [PATCH v2 0/4] cxl/events: Robustify event interrupt handling Anisa Su
2026-09-02 19:06   ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901002912.958-5-anisa.su@samsung.com \
    --to=anisa.su887@gmail.com \
    --cc=alison.schofield@intel.com \
    --cc=anisa.su@samsung.com \
    --cc=benjamin.cheatham@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=icheng@nvidia.com \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox