From: "Cheatham, Benjamin" <benjamin.cheatham@amd.com>
To: Anisa Su <anisa.su887@gmail.com>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] cxl/events: Return IRQ_NONE when no events were processed
Date: Tue, 1 Sep 2026 14:19:05 -0500 [thread overview]
Message-ID: <8e22c1c2-8098-492a-8162-3dd27507c853@amd.com> (raw)
In-Reply-To: <20260901002912.958-5-anisa.su@samsung.com>
On 8/31/2026 7:26 PM, Anisa Su wrote:
> cxl_event_thread() returns IRQ_HANDLED whether or not it found
> anything to do. Claiming every interrupt as handled means a device
> flooding its MSI vector is never detected.
>
> Return IRQ_NONE unless the Event Status register names a log to drain.
>
> Fixes: a49aa8141b65 ("cxl/mem: Wire up event interrupts")
> Signed-off-by: Anisa Su <anisa.su@samsung.com>
> ---
I'd mention that the MSI will eventually be disabled, but otherwise looks good
to me:
Reviewed-by: Ben Cheatham <benjamin.cheatham@amd.com>
Thanks,
Ben
next prev parent reply other threads:[~2026-09-01 19:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 0:26 [PATCH v2 0/4] cxl/events: Robustify event interrupt handling Anisa Su
2026-09-01 0:26 ` [PATCH v2 1/4] cxl/events: Bound get records loop in cxl_event_thread() Anisa Su
2026-09-01 0:41 ` sashiko-bot
2026-09-01 11:48 ` Li Ming
2026-09-01 17:59 ` Anisa Su
2026-09-01 19:17 ` Cheatham, Benjamin
2026-09-01 0:26 ` [PATCH v2 2/4] cxl/events: Validate the record count reported by the device Anisa Su
2026-09-01 19:19 ` Cheatham, Benjamin
2026-09-01 0:26 ` [PATCH v2 3/4] cxl/events: Bound the per-log Get Event Records loop Anisa Su
2026-09-01 0:43 ` sashiko-bot
2026-09-01 19:19 ` Cheatham, Benjamin
2026-09-01 0:26 ` [PATCH v2 4/4] cxl/events: Return IRQ_NONE when no events were processed Anisa Su
2026-09-01 0:38 ` sashiko-bot
2026-09-01 19:19 ` Cheatham, Benjamin [this message]
2026-09-02 8:27 ` [PATCH v2 0/4] cxl/events: Robustify event interrupt handling Anisa Su
2026-09-02 19:06 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e22c1c2-8098-492a-8162-3dd27507c853@amd.com \
--to=benjamin.cheatham@amd.com \
--cc=anisa.su887@gmail.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox