* [ndctl PATCH] test/security.sh: add missing jq requirement check
@ 2024-10-14 6:49 Li Zhijian
2024-10-14 6:56 ` Zhijian Li (Fujitsu)
2025-02-09 1:23 ` Alison Schofield
0 siblings, 2 replies; 4+ messages in thread
From: Li Zhijian @ 2024-10-14 6:49 UTC (permalink / raw)
To: nvdimm; +Cc: linux-cxl, Li Zhijian
Add jd requirement check explicitly like others so that the test can
be skipped when no jd is installed.
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
test/security.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/security.sh b/test/security.sh
index f954aec3e25a..d3a840c23276 100755
--- a/test/security.sh
+++ b/test/security.sh
@@ -220,6 +220,7 @@ else
fi
check_prereq "keyctl"
+check_prereq "jq"
uid="$(keyctl show | grep -Eo "_uid.[0-9]+" | head -1 | cut -d. -f2-)"
if [ "$uid" -ne 0 ]; then
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [ndctl PATCH] test/security.sh: add missing jq requirement check
2024-10-14 6:49 [ndctl PATCH] test/security.sh: add missing jq requirement check Li Zhijian
@ 2024-10-14 6:56 ` Zhijian Li (Fujitsu)
2024-10-15 15:03 ` Alison Schofield
2025-02-09 1:23 ` Alison Schofield
1 sibling, 1 reply; 4+ messages in thread
From: Zhijian Li (Fujitsu) @ 2024-10-14 6:56 UTC (permalink / raw)
To: nvdimm@lists.linux.dev; +Cc: linux-cxl@vger.kernel.org
On 14/10/2024 14:49, Li Zhijian wrote:
> Add jd requirement check explicitly like others so that the test can
> be skipped when no jd is installed.
Fix a typo
s/jd/jq
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> test/security.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/security.sh b/test/security.sh
> index f954aec3e25a..d3a840c23276 100755
> --- a/test/security.sh
> +++ b/test/security.sh
> @@ -220,6 +220,7 @@ else
> fi
>
> check_prereq "keyctl"
> +check_prereq "jq"
>
> uid="$(keyctl show | grep -Eo "_uid.[0-9]+" | head -1 | cut -d. -f2-)"
> if [ "$uid" -ne 0 ]; then
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ndctl PATCH] test/security.sh: add missing jq requirement check
2024-10-14 6:49 [ndctl PATCH] test/security.sh: add missing jq requirement check Li Zhijian
2024-10-14 6:56 ` Zhijian Li (Fujitsu)
@ 2025-02-09 1:23 ` Alison Schofield
1 sibling, 0 replies; 4+ messages in thread
From: Alison Schofield @ 2025-02-09 1:23 UTC (permalink / raw)
To: Li Zhijian; +Cc: nvdimm, linux-cxl
On Mon, Oct 14, 2024 at 02:49:51PM +0800, Li Zhijian wrote:
> Add jd requirement check explicitly like others so that the test can
> be skipped when no jd is installed.
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
Thanks! Applied to https://github.com/pmem/ndctl/commits/pending/
snip
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-09 1:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 6:49 [ndctl PATCH] test/security.sh: add missing jq requirement check Li Zhijian
2024-10-14 6:56 ` Zhijian Li (Fujitsu)
2024-10-15 15:03 ` Alison Schofield
2025-02-09 1:23 ` Alison Schofield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox