From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Cc: "Schofield, Alison" <alison.schofield@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
"Weiny, Ira" <ira.weiny@intel.com>
Subject: Re: [PATCH 4/7] tools/testing/cxl: Fix some error exits
Date: Fri, 4 Nov 2022 05:57:24 +0000 [thread overview]
Message-ID: <4793e5e64652e50c52a62a37699e2e9b1421c65e.camel@intel.com> (raw)
In-Reply-To: <166752184255.947915.16163477849330181425.stgit@dwillia2-xfh.jf.intel.com>
On Thu, 2022-11-03 at 17:30 -0700, Dan Williams wrote:
> Fix a few typos where 'goto err_port' was used rather than the object
> specific cleanup.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> tools/testing/cxl/test/cxl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good,
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index a072b2d3e726..133e4c73d370 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -695,7 +695,7 @@ static __init int cxl_test_init(void)
>
> pdev = platform_device_alloc("cxl_switch_uport", i);
> if (!pdev)
> - goto err_port;
> + goto err_uport;
> pdev->dev.parent = &root_port->dev;
>
> rc = platform_device_add(pdev);
> @@ -713,7 +713,7 @@ static __init int cxl_test_init(void)
>
> pdev = platform_device_alloc("cxl_switch_dport", i);
> if (!pdev)
> - goto err_port;
> + goto err_dport;
> pdev->dev.parent = &uport->dev;
>
> rc = platform_device_add(pdev);
>
next prev parent reply other threads:[~2022-11-04 5:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 0:30 [PATCH 0/7] CXL region creation fixes for 6.1 Dan Williams
2022-11-04 0:30 ` [PATCH 1/7] cxl/region: Fix region HPA ordering validation Dan Williams
2022-11-04 5:34 ` Verma, Vishal L
2022-11-04 21:36 ` Dave Jiang
2022-11-04 0:30 ` [PATCH 2/7] cxl/region: Fix cxl_region leak, cleanup targets at region delete Dan Williams
2022-11-04 5:39 ` Verma, Vishal L
2022-11-04 21:38 ` Dave Jiang
2022-11-04 0:30 ` [PATCH 3/7] cxl/pmem: Fix cxl_pmem_region and cxl_memdev leak Dan Williams
2022-11-04 5:55 ` Verma, Vishal L
2022-11-04 21:42 ` Dave Jiang
2022-11-04 0:30 ` [PATCH 4/7] tools/testing/cxl: Fix some error exits Dan Williams
2022-11-04 5:57 ` Verma, Vishal L [this message]
2022-11-04 21:43 ` Dave Jiang
2022-11-04 0:30 ` [PATCH 5/7] tools/testing/cxl: Add a single-port host-bridge regression config Dan Williams
2022-11-04 6:25 ` Verma, Vishal L
2022-11-04 17:52 ` Dan Williams
2022-11-04 0:30 ` [PATCH 6/7] cxl/region: Fix 'distance' calculation with passthrough ports Dan Williams
2022-11-04 6:42 ` Verma, Vishal L
2022-11-04 18:59 ` Dan Williams
2022-11-04 19:31 ` Verma, Vishal L
2022-11-04 21:58 ` Dave Jiang
2022-11-04 22:51 ` Dan Williams
2022-11-04 0:31 ` [PATCH 7/7] cxl/region: Recycle region ids Dan Williams
2022-11-04 6:31 ` Verma, Vishal L
2022-11-04 22:15 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4793e5e64652e50c52a62a37699e2e9b1421c65e.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox